- Issue created by @znerol
- 🇨🇭Switzerland znerol
Added both libraries in the PR (sodium and argon2). Its the way debian php is built.
It would be possible to minimize dependencies by not adding sodium at all and stick with argon2 library. From PHP 8.4, even that one is not necessary anymore. From that version onwards it is possible to use OpenSSL Argon2 implementation. Question here: Is it preferable to remain close to what distros are shipping or is it preferable to minimize dependencies.
Test command and example result for images with argon2 support:
% podman run -it --rm docker.io/drupalci/php-8.5-ubuntu-apache:dev php -r 'echo(password_hash("correct horse battery staple", PASSWORD_ARGON2ID));' $argon2id$v=19$m=65536,t=4,p=1$MzFSb1Q0MVg1NDBJOHQ4Nw$SYS269U5LJL2TEBG9t/glMS83kYMKB9mU9AJ4pnyO24
- 🇫🇷France andypost
Looks totally ok to me, I will commit it later tonight
btw I found OpenSSL argon is incomplete implementation so better to link it directly to the library.
so when there's no Argon2 headers some functionality is missing -
andypost →
committed 7c252a98 on dev authored by
znerol →
Issue #3530235 by znerol: Add libargon2 and libsodium
-
andypost →
committed 7c252a98 on dev authored by
znerol →
- 🇫🇷France andypost
I gonna slit it on commits as franken in dev repo only and looks can't build
-
andypost →
committed 3bef3421 on dev authored by
znerol →
Issue #3530235 by znerol: Add libargon2 and libsodium to PHP 8.3-ubuntu
-
andypost →
committed 3bef3421 on dev authored by
znerol →
- 🇫🇷France andypost
checking for Argon2 support... yes checking for libargon2... yes
and
checking for sodium support... yes checking for libsodium >= 1.0.8... yes
-
andypost →
committed 99411712 on production
Issue #3530235 by znerol: Add libargon2 and libsodium to PHP 8.3-ubuntu...
-
andypost →
committed 99411712 on production
-
andypost →
committed 417dd972 on dev authored by
znerol →
Issue #3530235 by znerol, andypost: Add libargon2 and libsodium to PHP 8...
-
andypost →
committed 417dd972 on dev authored by
znerol →
-
andypost →
committed 0dc068b6 on production
Issue #3530235 by znerol, andypost: Add libargon2 and libsodium to PHP 8...
-
andypost →
committed 0dc068b6 on production
-
andypost →
committed 4ff60c31 on dev authored by
znerol →
Issue #3530235 by znerol, andypost: Add libargon2 and libsodium to PHP 8...
-
andypost →
committed 4ff60c31 on dev authored by
znerol →
-
andypost →
committed aa6ad99d on production
Issue #3530235 by znerol, andypost: Add libargon2 and libsodium to PHP 8...
-
andypost →
committed aa6ad99d on production
Automatically closed - issue fixed for 2 weeks with no activity.