- Issue created by @longwave
- 🇬🇧United Kingdom longwave UK
It seems like we can now remove
Drupal.Commenting.VariableComment.Missingeverywhere we have an additional ignore because this looks to be handled correctly now - but not sure if doing that is really in scope here or if we just do it later. - 🇳🇱Netherlands bbrala Netherlands
Current changes look clean and nothing stands out as weird.
If we can remove more ignores we could, but might as well be in a followup.
- 🇳🇿New Zealand quietone
I tested with 3.29 locally and now all the
phpcs:ignore Drupal.Commenting.FunctionComment.MissingReturnCommentlines are ignored and phpcs is reporting errors when previously it was not. - 🇳🇿New Zealand quietone
Created 🐛 [regression] Can no longer ignore Drupal.Commenting.FunctionComment.MissingReturnComment Active .
I also asked about this two days ago in #coder but there hasn't been a response yet.
- 🇳🇱Netherlands bbrala Netherlands
This is the changelist:
https://git.drupalcode.org/project/coder/-/compare/8.3.28..8.3.29?from_p...There are changes to that sniff it seems.
I would suspect: https://git.drupalcode.org/project/coder/-/commit/78034f0a41956c4f8d3808...