- Issue created by @effulgentsia
- First commit to issue fork.
- Status changed to Needs review
9 months ago 4:48pm 18 March 2024 - πͺπΈSpain fjgarlin
Good question. D7 contrib modules (https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...) AND D7 core (https://git.drupalcode.org/project/drupal/-/blob/7.x/.gitlab-ci/pipeline...) would use the updated version, and we don't know that that would provoke.
Can we do versions in the chromedriver images? https://git.drupalcode.org/project/drupalci_environments/-/tree/dev/webd...
Same as what we do with PHP or database images? - πͺπΈSpain fjgarlin
We can leave the one we have now
drupalci/chromedriver:production
as it is, and maybe create a new onedrupalci/chromedriver-2024:production
(or whichever name is best) to use for places where we want/need a newer one. - π«π·France andypost
I think we should retag existing image too with version tag and CR can promote upgrade of latest version and if someone needs to use old version they can use :bc tag for example
- πͺπΈSpain fjgarlin
Happy with that too. Anything that can make it retrieve new vs old is good.
- π«π·France andypost
Now it needs review and testing new image
drupalci/chromedriver:dev
before creating production imageI already created copy of previous
production
image asdrupalci/webdriver-chromedriver:production-bc
anddrupalci/webdriver-chromedriver:production-106
I will pick the commit to build production
PS: after each build, manually or script should be updated to tag
drupalci/chromedriver
additionally to what CI doing
as it is used instead ofdrupalci/webdriver-chromedriver
by Drupal core$ docker tag drupalci/webdriver-chromedriver:dev drupalci/chromedriver:dev $ docker push drupalci/chromedriver:dev The push refers to repository [docker.io/drupalci/chromedriver] 28a4868ac1f2: Mounted from drupalci/webdriver-chromedriver ac2949c69757: Mounted from drupalci/webdriver-chromedriver dev: digest: sha256:13f72207bde04065dc889726ded3825f3e8fe6ae0af96c7fa8d79a117137edc3 size: 742
- πͺπΈSpain fjgarlin
#3423154: Change chromedriver for the new one used by core. β is testing the BC image (
drupalci/webdriver-chromedriver:production-bc
).
Everything seems to be working as expected: https://git.drupalcode.org/project/gitlab_templates/-/pipelines/123158 (the red light and the warnings are expected). - π«π·France andypost
Latest version ATM is
123.0.6312.134
https://chromereleases.googleblog.com/