Prevent crashing while file move, when file is not on the fileserver

The patch changes other things besides adding a try-catch. It removed the prepareDirectory function from the if check, which shouldn't have been changed. It doesn't throw an exception on failure; it returns false.

The test failures appear to be unrelated. I can't figure out what is causing them.

I found significant bugs in the original filefield_paths_filefield_paths_process_file() code.

It gets $temporary_scheme_name and $source_scheme_name incorrectly, causing the file move/rename not to happen at all in some cases.

This is fixed by using StreamWrapperManager::getScheme()

Hmm, the test that fails succeeded in PHP 7.4 with Drupal 9.5.

Needs rebase.

Thanks. Changes look good, but two PHPCS issues must be addressed before merging.

Thanks

Automatically closed - issue fixed for 2 weeks with no activity.