Deprecate system_check_directory()

Believe this is still valid.

Rerolled in MR. Please leave review comments in MR.

Small comment on MR

Looking at the CR, believe it should be fine but personally I'm big fan of before/after snippets.

Super close and will keep an eye out for this one.

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Addressed review comments and updated CR

Thanks feedback appears to be addressed

One comment on the MR.

Introduced logger channel as a dependency

A bunch of failures looks like a service is wrong.

The reason that only locale still uses this function is that we moved configuration of private/public/tmp stream wrappers to Settings in settings.php.

What if we do the same instead with this locale setting? Then we don't need any replacements.

(I had some concerns about removing as there are a handful of modules using this based on code search. But only 2 of those have a release that works on a supported core version, l10n_server and library_manager) and those don't seem to use it in current versions. So should be OK).

What if we do the same instead with this locale setting? Then we don't need any replacements.

That sounds great!