- First commit to issue fork.
- 🇮🇳India chandansha
Please Review the code and let me know if i missed anything.
Thanks!! - 🇺🇦Ukraine voleger Ukraine, Rivne
We need to improve the token integration test with cases of uploaded files without extension.
Hi,
currently a token replacement like [ffp-name-only-original].[ffp-extension-original] does not cover the case
of filenames ending with a dot but with no extension (e.g. file.).
In these cases the replacement ends up adding an extra dot at the end of the destination name giving file.. as result.
This is because the token regexes for the file names assume that there are always characters after the last dot when extracting the extension to subtract from the file name, I think this assumption can be relaxed.
I am going to send a patch which also covers some extra degenerate cases.
I tested the new regexes with these cases:
JFTR, I experienced the problem with files coming from a D6 site I am migrating to D8, in D6 uploading files with any extension was allowed.
Ciao,
Antonio
Needs work
1.0
Code
The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Please Review the code and let me know if i missed anything.
Thanks!!
We need to improve the token integration test with cases of uploaded files without extension.