Fix mismatch of $base_url with Symfony request object

Created on 22 June 2016, over 8 years ago
Updated 30 January 2023, about 2 years ago

Follow-up to #2528988: Remove the option to specify a base_url from within settings.php β†’

Problem/Motivation

- $base_url is not the same as $base_root . $request->getBasePath() in Symfony.
- This leads to lots of problems with TrustedRedirectResponse() as it thinks we redirect to an external path.
- Therefore #2528988: Remove the option to specify a base_url from within settings.php β†’ did not reach its goal to unify both approaches, but made it in fact almost impossible to work-around the mismatch

Proposed resolution

- Use Symfony function to find the script instead of $_SERVER['SCRIPT_NAME']

Remaining tasks

- Do it

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
Request processingΒ  β†’

Last updated about 22 hours ago

No maintainer
Created by

πŸ‡©πŸ‡ͺGermany Fabianx

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024