- Issue created by @voleger
- Merge request !4673Issue #3384272: Allow to validate Apache/Nginx configuration requirement for aggregation folder before enabling aggregation. β (Open) created by voleger
- last update
over 1 year ago Custom Commands Failed - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:04pm 30 August 2023 - πΊπ¦Ukraine voleger Ukraine, Rivne
The idea is to check the response status.
If the server is configured to return the file's content directly without passing a request through the PHP application on an empty file, the status code 404 will be returned.
In other cases, the controller will generate the aggregated file if files exist to aggregate or status code 400 if the aggregation file fails to be generated. In short, a response status code is different from 404.
I provided initial implementation. Feedback is welcome. - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 30,098 pass - Status changed to Needs work
over 1 year ago 8:17pm 30 August 2023 - πΊπΈUnited States smustgrave
Image styles would be amazing as that's bit me before.
Moving to NW for a change record though for the new setting.
- πΉπ·Turkey orkut murat yΔ±lmaz Istanbul
brilliant feature! thanks for the development:)
- π©πͺGermany zcht
The feature is really great, at this point a note that the patch is not compatible with Drupal 10.2. see details here in the issue: π system.performance.yml no longer considered after update Closed: works as designed
- πΊπΈUnited States SocialNicheGuru
I received two errors:
admin/config/development/performance|Warning: Undefined variable $config in Drupal\system\Form\PerformanceForm->buildForm() (line 170 of d10.2.x/html/core/modules/system/src/Form/PerformanceForm.php
admin/reports/status|1||Error: Call to a member function get() on null in Drupal\system\Form\PerformanceForm->buildForm() (line 170 of d10.2.x/html/core/modules/system/src/Form/PerformanceForm.php)
- Status changed to Needs review
11 months ago 9:00am 2 February 2024 - πΊπ¦Ukraine voleger Ukraine, Rivne
Thanks for the feedback. Adding new form elements to the config form was not the best idea.
So, I removed the validation button and performed validation on the appropriate checkbox checked change state.
Please review. - πΊπ¦Ukraine voleger Ukraine, Rivne
Regarding #5: I filled the follow-up issue β¨ Allow to validate Apache/Nginx configuration for image style files access Active for image style validation as it requires a different approach and different change scope to implement the new validation feature.
- πΊπ¦Ukraine voleger Ukraine, Rivne
test cases using different NGINX_VHOST_PRESET env var in Docker4Drupal development stack:
-drupal9
ordrupal8
validation will show the warning regarding server requirement;
-drupal10
validation will show that server configured properly - π©πͺGermany yannickoo Berlin
In case you need to apply the patch for a
10.1.x
Drupal you can find the patch attached π - Status changed to Needs work
10 months ago 4:33pm 8 February 2024 - πΊπΈUnited States smustgrave
Believe next step would be to get test coverage added.
- πΊπΈUnited States SocialNicheGuru
it would be nice to know which tests are failing
- πΊπΈUnited States SocialNicheGuru
I get a js error in the console and this error in my logs:
https://mysite/css/_validate.css|https://mysite/admin/config/development/performance|1||Symfony\Component\HttpKernel\Exception\BadRequestHttpException: The theme must be passed as a query argument in Drupal\system\Controller\AssetControllerBase->deliver() (line 132 of d10.2.x/html/core/modules/system/src/Controller/AssetControllerBase.php).
Adding the current state of the MR so that I can use it from composer patches securely.