Deprecate magic cancel submit handlers in views ui

Did the deprecation, needs a change record. Could possibly do a deprecation test but it would involve adding a test module with a form that calls $view->getStandardButtons similar to \Drupal\views_ui\Form\Ajax\ReorderDisplays and also declare a function with the magic naming convention.

Link related issue https://www.drupal.org/project/drupal/issues/3043725 ✨ Provide a Entity Handler for user cancelation Needs work

I don't think that issue is related

This needs a CR and the deprecation needs to be updated with the correct CR.

Deprecations don't need a test, the rest of the MR does look good.

I removed the unrelated issue.

Agree we don't normally need a test for a deprecation, unless it's a weird implementation. I think what I really meant that we don't actually have any evidence that the behaviour we're deprecating even works in the first place, so we could test for that as a deprecation test. But I don't know if it's worth it.

It feels very unlikely that anyone is relying on this, and fairly unlikely that it even works at all, so for me fine to skip deprecation test coverage here.

Great thanks! I created a CR and added a suggestion to change the deprecation to use the CR.

It could use a pass.

Applied the suggestion from the MR and updated the CR to make it specific to Views UI and with a more realistic example.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Huh it seemsmy comment was eaten but you got my suggestions anyway.

CR is far better now thanks!

Deprecation is correct now too.

Good to go.

Nice find. This is an excellent cleanup, but we should probably have subsystem maintainer signoff to ensure we're not leaving behind any trailing related bits etc. I'm technically only a maintainer for Views, not Views UI, so bumping back to NR. I'll also ping Lendude.

We might want to target Drupal 13 for this deprecation. I tried to search contrib, but ran into problems with the fuzziness (it refusing to do an exact search for _cancel().

Can't think of (or find) anything either that could possibly rely on this. So great clean up as far as I can tell.

So is this RTBC or need to be updated for D13? It seems incredibly niche.

I agree that it does seem very niche, but since it is a very dynamic public API that could be used in a lot of ways and I couldn't get a good sense of how many might still exist from the contrib search, I think I'd still deprecate it for Drupal 13 to be safe. .module files themselves aren't going to be removed before then, either, so it shouldn't be problematic to keep them around the extra two years. Thanks @mstrelan!

I tried to search contrib to see if this was widely used still, but ran into problems with the fuzziness (it refusing to do an exact search for _cancel().

Apparently this is a known issue - https://git.drupalcode.org/help/user/search/advanced_search.md#known-issues

The search query must not contain any of the following characters:
. , : ; / ` ' = ? $ & ^ | < > ( ) { } [ ] @

So perhaps http://codcontrib.hank.vps-private.net/search?text=_cancel%28&filename= is a better way to search.

Bumped removed version to 13.

We got sign off from the subsystem maintainer and bumped the removed version.

Good to go!

The main problem with the search was actually not being able to get a string literal match for the underscore, even when I dropped the parenthesis. But anyway, it's fine with a D13 deprecation. Thanks!

I made a couple small fixes to the CR and fixed a broken link in the MR.

Committed to 11.x and published the change record. Thanks!

xjm → closed merge request !12734

Reparenting