- Issue created by @flyke
- First commit to issue fork.
- Status changed to Needs review
4 months ago 8:05am 26 August 2024 - Status changed to Needs work
4 months ago 2:46pm 26 August 2024 - 🇩🇪Germany FeyP
Thanks for creating the issue. I can already say that the change of the main info.yml is not enough. Just run the tests once and you should see the problem. But we'll need a rebase anyway once I have enabled GitLab CI. I'm setting this to needs work for now for the rest of the required changes, but it is not a good time to work on it for now.
Also, the code changes are really straight forward and mostly covered by automated tools. What I could use help with is manual testing on all supported core versions once the changes are ready. Especially if you already use the module on D10 and would be willing to test an update to D11. But again: Soon, but not yet.
- First commit to issue fork.
- 🇧🇪Belgium JeroenT 🇧🇪
I made some changes to the MR and fixed all coding standards issues and failing tests:
https://git.drupalcode.org/issue/taxonomy_access_fix-3470214/-/pipelines...Only upgrade status is still showing a warning because we don't support Drupal 12 yet.
I also noticed that the tests were failing on 11.x-dev (as of 11.0.5) because of 🐛 The entity link label formatter should check URL access RTBC . So I had to make some changes to tests/src/Functional/VocabularyLabelAccessTest.php to fix the tests:
https://git.drupalcode.org/project/taxonomy_access_fix/-/merge_requests/... - 🇩🇪Germany FeyP
Thanks.
Only upgrade status is still showing a warning because we don't support Drupal 12 yet.
This is expected, the job tests compatibility with D12 now. It can be ignored.