The entity link label formatter should check URL access

Thank you for including test-only patch.

Only question would be the todo linking to follow up issues but will see if committers think that's an issue.

LGTM

@kksandr, thanks for issue and the MR!

I'm triaging RTBC issues → . I read the IS, which is missing several sections. I have restored those in case they are needed and so we have the 'remaining tasks' section. I read the one comment that gives thanks for the test only path and leaves a question for the committer team. I do not see evidence of a code review.

I applied the diff and read the comment with the @todo. The comment should be wrapped correctly and instead of referring to a file it should refer to a class, or method. That said, I then ran the test without the added user to see the failure. That was at /var/www/html/core/lib/Drupal/Core/ParamConverter/EntityConverter.php:149 which also has a todo. And that todo refers to https://www.drupal.org/node/2934192 → which is removing the block of code where the test is failing. It seems to me the @todo should point to that issue. Unless, I am missing something. Then, when that is fixed the creation of the user can be removed. (I tried that by applying that patch and removing the creation of the user and the test passed). Also, the anonymous user should only be created in the test where it is needed, instead instead of in the setup.

In testLabelFormatter, the value build[0]['#url'] is always unset. Surely, there should be a test for when it is set.

Setting to needs work for the above.