Use dependency injection

OK, but not all of the methods in that class are static! And the parent class already implements ContainerFactoryPluginInterface, so all we need to do is use the $instance = parent::create() pattern.

• defineOptions(), optionsSummary(), and buildOptionsForm() need the module_handler service injected
• buildOptionsForm() also needs the stream_wrapper_manager and plugin.manager.facets.facet_source services injected

whoops, wrong version

@benstallings thanks for the effort here, but there are still some places where we're not using dependency injection in this class at least, specifically the usages of the token service originally raised in this issue.

Ah, but of course that's exactly where we can't use DI, because the methods are static.

Nice, thanks Ben.

Automatically closed - issue fixed for 2 weeks with no activity.