- Issue created by @BenStallings
- 🇺🇸United States BenStallings
Looks like it's failing unit tests, so I must have broken something - flagging as Needs Work
phpstan reports, among other things:
------ -----------------------------------------------------------------------------------
Line src/Controller/SwitchController.php
------ -----------------------------------------------------------------------------------
54 Unsafe usage of new static().
🪪 new.static
💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ ----------------------------------------------------------------------------------------- -----------------------------------------------------------------------------------
Line src/Form/MasqueradeForm.php
------ -----------------------------------------------------------------------------------
47 Unsafe usage of new static().
🪪 new.static
💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ ----------------------------------------------------------------------------------------- ------------------------------------------------------------------------------
Line src/MasqueradeCallbacks.php
------ ------------------------------------------------------------------------------
87 \Drupal calls should be avoided in classes, use dependency injection instead
🪪 globalDrupalDependencyInjection.useDependencyInjection
------ ------------------------------------------------------------------------------------ -----------------------------------------------------------------------------------
Line src/Plugin/Block/MasqueradeBlock.php
------ -----------------------------------------------------------------------------------
43 Unsafe usage of new static().
🪪 new.static
💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ -----------------------------------------------------------------------------------
phpstan analyse -l0 masquerade
Use the $instance = parent::create() pattern.
make a MR.
Active
2.0
Code
Looks like it's failing unit tests, so I must have broken something - flagging as Needs Work