- Issue created by @BenStallings
- Merge request !77Issue #3522514 by benstallings, anybody, grevil: Many missing returns β (Merged) created by BenStallings
- Issue was unassigned.
- Status changed to Needs review
10 days ago 2:21pm 19 August 2025 - First commit to issue fork.
- π©πͺGermany Anybody Porta Westfalica
Whao, there are some heavy ones... @benstallings wouldn't it make sense to also add the return types on these methods?
- πΊπΈUnited States BenStallings
@anybody only if the parent classes support it. I didn't look into these specifically, but my experience has been that defining a return type in a child class's method can make it incompatible with the parent's method, so I didn't mess with that, I just addressed the phpstan warnings.
- π©πͺGermany Anybody Porta Westfalica
@benstallings correct - that should only be done if the parent class does it. Could you check that?
Also the MR has conflicts that need to be resolved. Guess you should have clicked "Update fork" before changing things manually :(
- πΊπΈUnited States BenStallings
@anybody I resolved the merge conflict, but I do not find any parent classes of these classes that specify return types. If you know of one that is relevant to this ticket, please let me know which one you're referring to. Thanks!
- π©πͺGermany Anybody Porta Westfalica
Thanks @benstallings - @grevil please do a quick review and then let's merge this. Quite some wild things found ;)
- First commit to issue fork.
- π©πͺGermany Grevil
That's wild... Especially, that "src/Plugin/EntityBrowser/Display/Standalone.php" is a live Entity Browser Display... I doubt that it is working at all π
@benstallings thanks for the fixes! π
-
grevil β
committed 5d7c7084 on 8.x-2.x authored by
benstallings β
Issue #3522514 by benstallings, anybody, grevil: Many missing returns
-
grevil β
committed 5d7c7084 on 8.x-2.x authored by
benstallings β