- 🇧🇪Belgium matthijs
matthijs → changed the visibility of the branch 3194171-bad-interaction-between to hidden.
- 🇧🇪Belgium matthijs
I've hidden the
3194171-bad-interaction-betweenbranch because it doesn't work as expected. Let's work on the other MR.
As stated in https://api.drupal.org/api/drupal/core!modules!migrate!src!Plugin!migrat...
when a migrate destination has overwrite_properties and the entity already exists only those properties specified are updated.
The problem I see is that when the destination is a translation the behavior is different from when is a new entity than when is a new translation for an existing entity. In summary, when a migration has translations as destination the overwrite_properties always kicks in when I feel the expected behavior for a new translation migration is that all the properties get saved and then further updates for that same translation respect the overwrite_properties option
Create a migration with node translations as destination and set overwrite_properties to only the title.
Since titles can't be null the migration will always fail
Introduce a new_translation_overwrite_all_properties that is false by default and when set to true it mimics the behavior of a new entity import by ignoring overwrite_properties when the translation is new (the entity had no previous translations for that entity)
Add the code for the new option and test
None
New option for migrations
None
Introduce a new_translation_overwrite_all_properties option for migration of new translations.
Needs work
11.0 🔥
migration system
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
matthijs → changed the visibility of the branch 3194171-bad-interaction-between to hidden.
I've hidden the 3194171-bad-interaction-between branch because it doesn't work as expected. Let's work on the other MR.