active-link.js doesn't support query arguments with an ampersand (and other characters))

Created on 24 February 2025, 5 months ago

Problem/Motivation

The data-drupal-link-query attribute contains a JSON string encoded using Json::encode(). This method also encodes <, >, ', &, and ", but these characters aren't encoded by JSON.stringify which results to the links not being marked as active.

Steps to reproduce

Add a main menu link for an existing node, but with a query argument containing an ampersand, e.g. /node/15?value=%26
Place a main menu block in your layout
Browse to the linked node and include the ampersand query argument -> the menu item ain't marked active

Proposed resolution

Change active-link.js to also encode special characters like the ampersand.

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

javascript

Created by

🇧🇪Belgium matthijs

Live updates comments and jobs are added and updated live.

Merge Requests

!11285active-link.js doesn't support query arguments with an ampersand (and other characters))
Open
🇧🇪Belgium matthijs
updated 5 months ago

Comments & Activities

Issue created by @matthijs
Comment 5 months ago →
🇧🇪Belgium matthijs
Merge request !11285Issue #3508677: Fix support for special characters in active-link.js → (Open) created by matthijs
Pipeline finished with Failed
5 months ago
#432775
Comment 5 months ago →
🇧🇪Belgium matthijs
The MR adds a JavaScript callback to properly encode the current query parameters.
Pipeline finished with Failed
5 months ago
Total: 96s
#432795
Comment 5 months ago →
🇺🇸United States smustgrave
Pipeline appears to have issues but probably need a test case to show this problem also.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024