Domain Access: Expand node_grants support for update and delete operations

Rebased against the latest dev.

Patches must be set to Needs Review to trigger tests.

The last submitted patch, 13: 3284795-domain-access-update-operation-13.diff, failed testing. View results →

I've rerolled this patch to work with 2.0.x

Additional note: This patch fixes an issue i was having of not being able to edit unpublished nodes.

Hi @lincoln-batsirayi, could you create a new MR for the 2.0.x branch? That would be great.

Hi @mably this was my first time ever doing a MR so there's a chance I’ve done something wrong but i did try my best to follow the instructions in all the available documentation.

The main thing to note here is that the original MR in gitlab is still pointing at `8.x-1.x` because that's when this issue created. Now this might be wrong but inside the branch for this issue i merged in 2.0.x (since i want these changes available in there) and then i added in the changes for this patch and pushed those too but i don’t know if this was the correct thing or not, if it wasn’t please let me know what i should've done.

I changed the MR's target to 2.0.x. Looks like a rebase is still needed though.

I tried to do the rebase but unfortunately it looks like i don't have permission force push the branch because i didn’t create the original fork issue, so I'm not really sure where to go from here... any ideas?

Can you try to create a new branch/MR then?

lincoln-batsirayi → changed the visibility of the branch 3284795-domain-access-update-operation to hidden.

Okay i think that's done now @mably, my apologies for the sh*t show on this, it was my first time with this work stream / workflow but it was invaluable to learn so thanks for that :)

Hi @lincoln-batsirayi, it looks like some tests need to be updated.

Working on it!!

Please review!!

@divyansh.gupta check the Gitlab CI pipeline results. Still some warnings.

And PHPUnit job is failing with this in the logs:

Drupal\Core\Test\Exception\MissingGroupException: Missing @group annotation in Drupal\Tests\domain_access\Functional\DomainAccessUnpublishedGrantsTest in /builds/project/domain/web/core/lib/Drupal/Core/Test/TestDiscovery.php:342

Remember to check that the tests pass all fine before setting to "Needs review". Thanks.

Now all tests are running green,
Please review!!

Thanks a lot @divyansh.gupta, I'll have a look at it.

Let's try to add this to the next release.

Automatically closed - issue fixed for 2 weeks with no activity.