You're totally right. This patch didn't went through. Pity we cannot reinstate this issue.
Also checked patch on #15 and it does the job more cleanly than older patches.
+1
Not compatible with 3.x
+1
Patch #7 does seem to work. Thanks!
#10: If multiple selections are allowed, the "Add select all/none links" checkbox does not for the Links widget.
It does show for you disable multiple selections.
I created a initial setup for the submodule.
There is still the issue of data loss regarding this setting with the upgrade.
Added MR as patch
Added patch for 1.24 specifically.
In combination with https://www.drupal.org/project/entity_reference_revisions/issues/3150084 🐛 Non-translatable fields can only be changed when updating the current revision. Needs review , the issue in #15 should be partly solved.
This testmodule doesn't exist anymore.
MR !13 seems to fix this issue. Bumped to RTBC for visibility.
This fixes the issue on our end as well.
Thanks!
Works as expected
Looks good! Thanks for the fast follow-up.
Had to do with the request of our client. They need to receive this data in my suggested format.
I don't mind creating a local patch just for our use-case; I follow the preference of the majority.
#45 still works in Drupal 10.1.4.
I will not change the Status, as I don't know if it has been rebased / retargeted.
I know it is a hacky method, but it does the job for the moment.
By the way, I was looking at the getCssClassName function.
This is a very unreliable method to create classes, as it changes dependending on the amount of instances and position.
I know it is to be sure no style is overridden, but as a front-end developer you are nothing with the 'class' option.
Maybe drop the versioning of LP?
The composer should handle the requirement then.
I can agree on that. The intention was to, at least, make the site builder aware.
Applied feedback from #9.
Feedback from #6 has been applied. Thanks for reviewing it.
#4: With this patch, it should not be needed as it is done automatticaly.
Not compatible with 2.1.2
Following feedback from #5:
- TOC is optional, but can be added;
- Markdown best practises requires you to add blank lines before and after titles: https://www.markdownguide.org/basic-syntax#heading-best-practices. It even says it in Drupal's documentation.
antoineh → created an issue.
Any updates around this?
antoineh → created an issue.