Update description on settings page

Created on 26 June 2023, about 1 year ago
Updated 4 July 2023, 12 months ago

Problem/Motivation

More description is needed in '/admin/config/content/layout_paragraphs/limit'.
Maybe also update Link name.

Proposed resolution

Updated description on '/admin/config/content/layout_paragraphs/limit'.

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇧🇪Belgium antoineh Mechelen, 🇧🇪

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @antoineh
  • @ant1 opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • 🇧🇪Belgium antoineh Mechelen, 🇧🇪
  • 🇮🇳India Raveen Kumar

    I have reviewed and implemented the MR! provided by @ ant1. The MR! has been implemented successfully.
    I am attaching my screenshot for your reference. Please review.
    And Thank You.

  • Status changed to RTBC about 1 year ago
  • 🇭🇺Hungary nagy.balint

    Thanks!

    I think that the Note is not clear enough, and should be something like:

    Only the layouts that have been enabled in the settings of the 'Layout Paragraphs' behavior will be shown here.

  • Status changed to Needs review 12 months ago
  • 🇧🇪Belgium antoineh Mechelen, 🇧🇪

    Feedback from #6 has been applied. Thanks for reviewing it.

  • Status changed to RTBC 12 months ago
  • Verified the MR8, the note is updated. Added screenshot for reference, RTBC++

  • Status changed to Needs review 12 months ago
  • 🇦🇹Austria hudri Austria

    This MR changes the same message as #3371967 📌 Allow to toggle between allow-list and block-list Fixed :

    I think if we merge both messages from both MRs it might become a bit confusing, maybe we can get maintainer feedback here.

  • 🇦🇹Austria hudri Austria

    Thinking about it, we have 2 levels of filters a site architect / this module has to be aware of:

    1. Paragraph type filter on the host entity paragraph field (e.g. field.field.NODE_TYPE.FIELD_FOO). This filter is not visible in this form, because it is on field level, not in layout or region definition. Even though all bundles are shown here, it will still affect everything here.
    2. Layout filter by behavior plugin on the parent layout paragraph entity (e.g. paragraphs.paragraph_type.LAYOUT_PARAGRAPH)
      This is reflected in the form, disabled layouts are omitted here.

    I'd suggest one combined message "Note that there might be additional filters on the paragraph host field and on the layout paragraph behavior." to avoid cluttering the UI too much. I'm a fan of short and concise messages, I don't think we need the full explanation of this comment directly in the UI.

  • Status changed to Needs work 12 months ago
  • 🇧🇪Belgium antoineh Mechelen, 🇧🇪

    I can agree on that. The intention was to, at least, make the site builder aware.

Production build 0.69.0 2024