- Issue created by @ant1
- @ant1 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:36pm 26 June 2023 - 🇮🇳India Raveen Kumar
I have reviewed and implemented the MR! provided by @ ant1. The MR! has been implemented successfully.
I am attaching my screenshot for your reference. Please review.
And Thank You. - Status changed to RTBC
over 1 year ago 9:36am 27 June 2023 - 🇭🇺Hungary nagy.balint
Thanks!
I think that the Note is not clear enough, and should be something like:
Only the layouts that have been enabled in the settings of the 'Layout Paragraphs' behavior will be shown here.
- Status changed to Needs review
over 1 year ago 8:28am 4 July 2023 - 🇧🇪Belgium ant1
Feedback from #6 has been applied. Thanks for reviewing it.
- Status changed to RTBC
over 1 year ago 8:38am 4 July 2023 Verified the MR8, the note is updated. Added screenshot for reference, RTBC++
- Status changed to Needs review
over 1 year ago 8:46am 4 July 2023 - 🇦🇹Austria hudri Austria
This MR changes the same message as #3371967 📌 Allow to toggle between allow-list and block-list Fixed :
I think if we merge both messages from both MRs it might become a bit confusing, maybe we can get maintainer feedback here.
- 🇦🇹Austria hudri Austria
Thinking about it, we have 2 levels of filters a site architect / this module has to be aware of:
- Paragraph type filter on the host entity paragraph field (e.g.
field.field.NODE_TYPE.FIELD_FOO
). This filter is not visible in this form, because it is on field level, not in layout or region definition. Even though all bundles are shown here, it will still affect everything here. -
Layout filter by behavior plugin on the parent layout paragraph entity (e.g.
paragraphs.paragraph_type.LAYOUT_PARAGRAPH
)
This is reflected in the form, disabled layouts are omitted here.
I'd suggest one combined message "Note that there might be additional filters on the paragraph host field and on the layout paragraph behavior." to avoid cluttering the UI too much. I'm a fan of short and concise messages, I don't think we need the full explanation of this comment directly in the UI.
- Paragraph type filter on the host entity paragraph field (e.g.
- Status changed to Needs work
over 1 year ago 9:57am 4 July 2023 - 🇧🇪Belgium ant1
I can agree on that. The intention was to, at least, make the site builder aware.