Support Server-Side GTM on 2.x

Created on 29 February 2024, about 1 year ago

There is an issue about supporting server side gtm on 8.x, but with 2.x this doesn't work. So I've created a patch for v 2.x

Feature request
Status

Active

Version

2.0

Component

Code

Created by

🇧🇪Belgium kensae

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kensae
  • Merge request !73Support server-side gtm on 2.x → (Open) created by kensae
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    50 pass, 1 fail
  • Status changed to Needs work about 1 year ago
  • 🇩🇪Germany Anybody Porta Westfalica

    A test is failing currently.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update 12 months ago
    54 pass
  • 🇧🇪Belgium kensae

    I've fixed the failing test. It didn't include the hostnames.

  • First commit to issue fork.
  • Pipeline finished with Success
    8 months ago
    Total: 215s
    #238249
  • First commit to issue fork.
  • Pipeline finished with Failed
    5 months ago
    Total: 181s
    #331983
  • 🇫🇮Finland tvalimaa

    Patch is not apply and when I did some manually patching it did some multiple codes which I though that "fix" but I broke it more. I reverted my changes and everything should be how there where. Sorry about that.

    Otherwise I got this working putting changes manually and do some code changes.

  • Pipeline finished with Failed
    5 months ago
    Total: 262s
    #332006
  • First commit to issue fork.
  • Pipeline finished with Failed
    3 months ago
    Total: 297s
    #377134
  • I made changes to get rid of google_tag_update_8202.
    Using hook_upate may cause a conflict when merging with the main branch or when using other patches, so if we can get rid of it, it's better to do so.
    Here's the patch for v2.0.7

Production build 0.71.5 2024