Account created on 3 October 2013, over 11 years ago
  • Drupal Developer at Druidย 
#

Merge Requests

More

Recent comments

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Using distinct on admin/content view don't work for me. It still shows content dublicated.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

tvalimaa โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

patch #7 works on my project with Drupal 10.3.9
<span class="translation-entity-all-languages">(all languages)</span> is now (all languages)

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Hi, i can create empty groups and group content with this patch but how about users? The group creator automatically becomes a member and adding member after group if created gives This entity can only be saved in the default workspace.. Is that related group module or overall user workspaces?

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

tvalimaa โ†’ changed the visibility of the branch 3491027-php-fatal-error to hidden.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Patch is not apply and when I did some manually patching it did some multiple codes which I though that "fix" but I broke it more. I reverted my changes and everything should be how there where. Sorry about that.

Otherwise I got this working putting changes manually and do some code changes.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

tvalimaa โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

I created code change and settings for view activity

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

tvalimaa โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Now API content has change so :
This is never be false because it always have array key.
if (!array_key_exists('original_hash', $id_map)

This is ok.
$id_map['hash'] !== $id_map['original_hash'])

Maybe?
if (!empty($id_map['original_hash']) && $id_map['hash'] !== $id_map['original_hash'])

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Hi, I tested patch #39 and it looks like working like #32 with translations

drush mim --group=activity --update
 [notice] Processed 334 items (0 created, 301 updated, 0 failed, 33 ignored) - done with 'activities'
 [notice] Processed 334 items (0 created, 321 updated, 0 failed, 13 ignored) - done with 'activities_en'
destination:
  plugin: entity:node
  new_revision: yes
destination:
  plugin: entity:node
  translations: true
  new_revision: yes
๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Paytrail works fine in testing mode with VAT% set to 25.5 on commerce settings

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

I have same problem with these versions samlauth: 8.x-3.9 & externalauth: 2.0.5 and that merge request !18 is solving my problem.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

hmm I didn't get those errors even I use same line on my local. Anyway I made commit based #5 comment

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa
FILE: user_email_verification.module
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\Display\EntityViewDisplayInterface.
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/views/filter/EmailVerification.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Plugin\views\filter\FilterPluginBase.
--------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: src/Controller/UserEmailVerificationVerifyExtended.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------
 93 | ERROR | Unnecessarily gendered language in a comment
-----------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: src/Controller/UserEmailVerificationVerify.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------
 94 | ERROR | Unnecessarily gendered language in a comment
---------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: src/Event/UserEmailVerificationVerifyEvent.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\user\UserInterface.
---------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: src/Event/UserEmailVerificationDeleteAccountEvent.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\user\UserInterface.
----------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: src/Event/UserEmailVerificationCreateVerificationEvent.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\user\UserInterface.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: src/Event/UserEmailVerificationBlockAccountEvent.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\user\UserInterface.
---------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: user_email_verification/src/UserEmailVerification.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
 20 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\user_email_verification\Event\UserEmailVerificationBlockAccountEvent.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Yes it's look like and the fix is same kind

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

I have the same problem that translation shows order column with selections.

#4 comment commit id looks like fixed the problem. After trying that commit id order column and selections are gone.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

#28 patch dosen't seems to work 100% for me. End date clock time is wrong.

My node start date field is 03.04.2024 14.00 and end date field 03.04.2024 15.00. When I download ics-file and open calendar the calendar put 03.04. 14.00 - 03.04. 14.00

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

#175 gives me :

PHP Fatal error:  Cannot redeclare Drupal\language\ConfigurableLanguageManager::setCurrentLanguage() in public/core/modules/language/src/ConfigurableLanguageManager.php on line 305

Drupal 10.1

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

My problem seemed to be on custom code which calls createFilterQuery function.

Problem was that custom code had bug which allow send empty $value to createFilterQuery. When $value was empty and createFilterQuery will set $value be array then escapePhrase will gives error because code can allow $value be empty array and escapePhras expect $value be string then gives error.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

I have the same problem with same kind of settings and Drupal 10.1.4. #22 patch didn't work.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

#42 looks like working with 1.0 rc-7.

I have now check and calculate revisions count per node and node translations after clicking delete revisions on node.

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

That patch worked, thx

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Patch #32 worked for me but it didn't change revision author or revision message. Revision author and message was same than previous revision...

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

I got this error by following steps and how i fixed it:
- I create a new content type
- I added existing Scheduled publish field
- When I went node add form it gave me PHP fatal error

Fix was:
- I went config/workflow/workflows
- I edit existing workflow
- I added my a new content type to Applies by Content types settings

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

I got message:
For this to work correctly, all tables must have a primary key. The following table(s) do not have a primary key: search_api_db_fulltext_1.

What I did was custom update_hook for custom module.install file

function mymodule_update_10001() {
  \Drupal::database()->schema()->addPrimaryKey('search_api_db_fulltext_1', ['item_id']);
}
๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

I found this issue by accidentally. I made patch for version 2.1.1

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

here is that patch for version 1.4

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

Patch is working but there is still some case where is not working.

Like I have 2 translations on node x:
- Finnish translation is unpublished and I change that for published (original content)
- English translation is published and I change that for unpublished (translation)

So if I change both node statuses on same cron run then both statuses aren't changing so they are same status before cron run.
- Finnish was unpublished and is still unpublished even I wanted that published
- English was published and is still published even I wanted that change to unpublished

๐Ÿ‡ซ๐Ÿ‡ฎFinland tvalimaa

I have same issue that content type is using paragraphs. I think it's just easier and fastest just create custom module and use this module code base for some help. Basic idea is just use webform submission hook and tigger own custom function to create node programmatically without any UI mapping or settings. Other thing what I can do is extend this module code and override mapping part but maybe simple submission hook + custom node creating is fastest.

Production build 0.71.5 2024