- Issue created by @tvalimaa
- Status changed to Needs review
6 months ago 1:30pm 6 June 2024 - Status changed to RTBC
6 months ago 6:55am 7 June 2024 - š®š³India dev16.addweb
I have reviewed the merge request here and tested PHPCS. No issues are present in PHPCS now also single user role functionality working fine.
addweb@addweb-HP-ZBook-15-G2:~$ .config/composer/vendor/squizlabs/php_codesniffer/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css Drupal8-vagrant/web/web/contribution/drupal-10-3/web/modules/custom/single_user_role/ addweb@addweb-HP-ZBook-15-G2:~$
- Status changed to Active
3 months ago 6:58pm 7 September 2024 - š®š¹Italy apaderno Brescia, š®š¹
This issue does not have a MR, yet.
- @avpaderno opened merge request.
- š®š¹Italy apaderno Brescia, š®š¹
- @avpaderno opened merge request.
- Status changed to Needs review
3 months ago 7:15pm 7 September 2024 - š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3452991-gitlab-ci-reports to hidden.
- Status changed to RTBC
3 months ago 5:25am 9 September 2024 - šµšPhilippines paraderojether
Hi,
I reviewed MR!7, applied against Single User Role 8.x-1.x-dev and confirmed phpcs issues are now resolved.
PHP_CodeSniffer
ā single_user_role git:(8.x-1.0-beta2) curl https://git.drupalcode.org/project/single_user_role/-/merge_requests/7.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4773 0 4773 0 0 2846 0 --:--:-- 0:00:01 --:--:-- 2859 patching file .gitlab-ci.yml patching file single_user_role.module patching file 'src/Form/SingleUserRoleConfigForm.php' ā single_user_role git:(8.x-1.0-beta2) ā cd .. ā contrib git:(1.0.0) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig single_user_role ā contrib git:(1.0.0) ā
It also passed on the Gitlab CI: https://git.drupalcode.org/issue/single_user_role-3452991/-/jobs/2681621
Thank you.