Test support for 25.5% VAT

Created on 16 July 2024, 7 months ago

Problem/Motivation

Drupal Commerce 2 supports decimals in VAT%.
Paytrail added support for that in June 20 https://www.google.com/amp/s/www.paytrail.com/kumppaniportaali/uutiset/a...

Proposed resolution

Test if new VAT works out of the box. If not create a follow-up issue to implement support.

Remaining tasks

  1. Test payments with 25.5% VAT
📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇫🇮Finland simohell

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @simohell
  • 🇫🇮Finland tvalimaa

    Paytrail works fine in testing mode with VAT% set to 25.5 on commerce settings

  • Status changed to Needs work 2 months ago
  • 🇫🇮Finland jgullstr

    Currently, the payments pass, but get registered remotely with a truncated VAT rate. "setVatPercentage"-calls in the module cast VAT percentages to integer values, which removes the fractional part of the VAT rate, eg 25.5 turns into 25.

    The API library probably needs to be regenerated before decimal values can be used, I have created an issue for that here.

  • First commit to issue fork.
  • 🇫🇮Finland tuutti

    Thanks! This should be fixed in 3.1.0 release.

    The updated OpenAPI spec introduced some BC breaks and I had to bump the API library version. You might have to run composer update with -W flag (composer update drupal/commerce_paytrail -W) to get the updated API library.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024