- 🇫🇮Finland tvalimaa
Patch is working but there is still some case where is not working.
Like I have 2 translations on node x:
- Finnish translation is unpublished and I change that for published (original content)
- English translation is published and I change that for unpublished (translation)So if I change both node statuses on same cron run then both statuses aren't changing so they are same status before cron run.
- Finnish was unpublished and is still unpublished even I wanted that published
- English was published and is still published even I wanted that change to unpublished - 🇮🇪Ireland lostcarpark
Thanks for your work on this. Sounds like there is a little more work needed to complete.
I think it would be worthwhile designing some automated tests to demonstrate the issue in the current release, and verify the fix works in the cases above.
- Status changed to Needs work
4 months ago 7:56pm 31 August 2024 - 🇮🇪Ireland lostcarpark
I would love to have support for translations, so would be keen to get this included in a release soon.
However, I feel there is some work needed to complete this.
- Move from a patch to a merge request
- Make sure it doesn't need updating to reflect changes to the module
- Cover off the exceptions described above
- Add test cases to verify the basic functionality for translations. I feel this is important, as not everyone uses this feature, and we need to cover against future developers accidentally breaking the functionality
For the last, I'd be happy to work on some test cases, but I haven't written multilingual tests before, so it would really help if someone could outline the steps to test the functionality from a fresh Drupal install.
I'm setting back to needs work, as it needs some work before it would be ready to merge into the module.