Support entity translations

Patch is working but there is still some case where is not working.

Like I have 2 translations on node x:
- Finnish translation is unpublished and I change that for published (original content)
- English translation is published and I change that for unpublished (translation)

So if I change both node statuses on same cron run then both statuses aren't changing so they are same status before cron run.
- Finnish was unpublished and is still unpublished even I wanted that published
- English was published and is still published even I wanted that change to unpublished

Thanks for your work on this. Sounds like there is a little more work needed to complete.

I think it would be worthwhile designing some automated tests to demonstrate the issue in the current release, and verify the fix works in the cases above.

I would love to have support for translations, so would be keen to get this included in a release soon.

However, I feel there is some work needed to complete this.

1. Move from a patch to a merge request
2. Make sure it doesn't need updating to reflect changes to the module
3. Cover off the exceptions described above
4. Add test cases to verify the basic functionality for translations. I feel this is important, as not everyone uses this feature, and we need to cover against future developers accidentally breaking the functionality

For the last, I'd be happy to work on some test cases, but I haven't written multilingual tests before, so it would really help if someone could outline the steps to test the functionality from a fresh Drupal install.

I'm setting back to needs work, as it needs some work before it would be ready to merge into the module.

Created Draft MR.

Ported patch by @florianmuellerch, and fixed comments above. The issue was, when querying using simple condition $query->condition('langcode',$language->getId()); the query set only the base table langcode. The fields data tables langcodes actually stays unset. So, this worked only if entity default translation had scheduled_publish translated, the translation will also update. But, if you set translation's scheduled_publish field value, but the original translation value is empty, the query won't include this entity.

This is described in an issue https://www.drupal.org/project/drupal/issues/3092835 🐛 Entity query not working with multiple languages. Active

What I did is now we add a query alter tag to entity query, and then there is a hook scheduled_publish_query_scheduled_publish_language_aware_alter which adds langcode condition to field revision table. I can't think of any other solution, because apparently you can't add select conditions straight to entity query, it works only with field conditions.

This kinda sounds complicated, but if you have any questions please ask, I'm terrible at explaining things

Now we have another issue I can't wrap my head around:

In Content language and translation page (/admin/config/regional/content-language) of Drupal, users can select which fields are translated and which are not. This solution will work fine while both scheduled_publish field and moderation state field are translated and unique for each translation.

So the issue is, what will happen if scheduled_publish is translated but moderation state is not? How the system should behave? And what if scheduled_publish is untranslated but moderation state is? In this case, we could foreach all entity translations and set moderation state where it is valid, but isn't it confusing?

Maybe we should create a checks in widget and configuration update subscriber, to error when scheduled_publish and moderation state translation settings are different?

I decided not to experiment with tests until this inconsistency is resolved

Hi @dlevchik
Thanks a lot for your work on the issue!
I am currently unable to invest time into this, would love if anyone could join on the discussion :)

I'm not going to have time for a couple of weeks, but I will review as soon as I can.

If anyone else has time to look at it before then, please go ahead.