Contrib.social

Gin toolbar skips background colour, but not when Core Navigation module is enabled

Open on Drupal.org →
Created on 23 October 2024, 9 months ago

Problem/Motivation

The code checks for base toolbar, which gets replaced if you enable Core Navigation module:

// Only apply text and background color if not using gin_toolbar
if (!$body.hasClass('gin--vertical-toolbar') && !$body.hasClass('gin--horizontal-toolbar') {

Steps to reproduce

Enable Gin & Navigation

Proposed resolution

// Only apply text and background color if not using gin_toolbar
if (!$body.hasClass('gin--vertical-toolbar') && !$body.hasClass('gin--horizontal-toolbar'  && !$body.hasClass('gin--core-navigation')) {

Remaining tasks

MR

User interface changes

Background not shown when Navigation module enabled in Gin

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Active

Version

4.0

Component

Code

Created by

🇬🇧United Kingdom scott_euser

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @scott_euser
  • Merge request !68Resolve #3482707 "Gin toolbar navigation" → (Open) created by scott_euser
  • Comment 9 months ago →
    🇬🇧United Kingdom scott_euser

    Before:

    After:

  • Pipeline finished with Success
    9 months ago
    Total: 133s
    #318065
  • Comment 7 months ago →
    🇬🇧United Kingdom scott_euser

    Updated to fix merge conflict from latest 4.x.

  • Pipeline finished with Success
    7 months ago
    Total: 160s
    #369202
  • Issue was unassigned.
  • Status changed to Needs review 6 months ago
  • First commit to issue fork.
  • Pipeline finished with Success
    6 months ago
    Total: 141s
    #388686
  • Comment 5 months ago →
    🇵🇱Poland bronismateusz

    Can confirm that this works with `Gin 4.0.0` and the new navigation, however, if I select the toolbar integration, the colour for the environment does not show anywhere. If I don't select it, it shows a horizontal bar at the top of the page, which is ok, but not as aesthetically pleasing as the vertical bar on the left present with other navigation settings.

    Before:

    After:

    Gin settings:

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024