Contrib.social

Export Button, make it styleable with CSS

Open on Drupal.org →
Created on 22 December 2011, over 13 years ago
Updated 22 February 2025, about 1 month ago

The current export button uses an image with a hardcoded image path: 

<a href="....">
           <img src="/sites/all/modules/views_data_export/images/csv.png" 
                   alt="Download CSV File" 
                   title="Download CSV File" height="14" width="36">
 </a>

That is hard for a themer to overwrite; you'd have to use jQuery to manipulate the dom directly.

It would be great if this was stylable instead with CSS. Instead of the imgage tag, you could use some inner divs and then set the background image using CSS.

✨ Feature request
Status

Needs work

Version

1.0

Component

Code

Created by

hoporr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 10 months ago →
    🇺🇸United States AaronBauman Philadelphia

    +1 for this feature request

  • First commit to issue fork.
  • Comment about 1 month ago →
    🇧🇪Belgium ant1

    ant1 → changed the visibility of the branch 1379672-export-button-styling to hidden.

  • Comment about 1 month ago →
    🇧🇪Belgium ant1

    Seems this module provides templating for the export icon for some time now, so I assume this has been solved.

  • Comment about 1 month ago →
    🇺🇸United States AaronBauman Philadelphia

    The patch provides detailed changes, and this thread contains a robust discussion about why those changes are necessary.

    @ant1, Your comment does not add to the discussion, or provide any response to the proposal.

    Resetting to Needs Review.

  • Comment 15 days ago →
    🇮🇹Italy trickfun

    Why doesn't provide a better button? or a button like action?
    I don't want override button inside admin theme.
    Thank you

  • Comment 1 day ago →
    🇺🇸United States luke.leber Pennsylvania

    Moving back to needs work due to...

    1. The issue summary describing the problem but not clearing laying out a proposed resolution.
    2. This issue has a visible patch (that doesn't apply to HEAD) -- patch workflow is antiquated and will not run automated tests anymore.
    3. This issue having 2 forks (which are hidden by default) -- both of which go different directions than the patch.

    All in all, I don't think this can be "needs review". There needs to be a written-down plan and one up to date merge request to be eligible for needing review IMHO.

    That all said something definitely needs to be done here. The tap area for the current out of the box experience is too small to pass accessibility audits, so tagging with accessibility.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024