- Issue created by @antoineh
- First commit to issue fork.
- Status changed to Needs review
4 months ago 12:43pm 7 March 2024 - ๐ฎ๐ณIndia viren18febS
Please review the commit for fixes of the issue.
https://git.drupalcode.org/issue/site_settings-3426285/-/commit/fc5f67b6... - Status changed to Needs work
3 months ago 6:13am 12 March 2024 - ๐ฌ๐งUnited Kingdom scott_euser
Thanks! Just a small comment, seems safer maybe than relying on isNew() (even if currently isNew() is true even if config is old) https://git.drupalcode.org/issue/site_settings-3426285/-/commit/fc5f67b6...
I think you need to checkout the branch + create a merge request still, that seems to be missing.
In any case thanks for spotting this and helping sort!
- ๐บ๐ฆUkraine Bobik
bobi-mel โ made their first commit to this issueโs fork.
- ๐บ๐ฆUkraine Bobik
Hello
@scott_euser.
I have reviewed this issue and the @viren18febS commit.
I found that the issue was created for the 2.0 branch of the module. Therefore, I created a separate branch for the 2.0 version of the module, made the fixes as per your recommendation and created a merge request. Please check again if everything is done correctly -
bobi-mel โ
committed d6fe70b0 on 2.0.x
Issue #3426285: Incorrect uninstall
-
bobi-mel โ
committed d6fe70b0 on 2.0.x
- Status changed to Fixed
3 months ago 8:24pm 4 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.