- Issue created by @akalam
- @akalam opened merge request.
- Status changed to Needs review
almost 2 years ago 8:09am 18 May 2023 - 🇪🇸Spain akalam
Added a MR with the first approach: Add dependency on pathauto.
- 🇧🇪Belgium johanvdr
Based on https://www.drupal.org/project/node_keep/issues/3361172#comment-15056012 🐛 Node keep can be wrongly installed without creating the alias_keeper field Needs work from @akalam I created a patch following the approach: Add dependency on pathauto.
- 🇧🇪Belgium johanvdr
Patch partially did not apply. Something with the last line and *.info.yml adding extra lines when performing composer install.
- Status changed to Needs work
almost 2 years ago 3:59pm 23 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Pathauto should stay an optional dependency. Otherwise, that part of the functionality should be extracted into a submodule. The module shouldn't require to install pathauto.
- First commit to issue fork.
- 🇧🇪Belgium ant1
I created a initial setup for the submodule.
There is still the issue of data loss regarding this setting with the upgrade. - Status changed to Needs review
about 2 months ago 8:07am 12 February 2025 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
@ant1 thanks for the work done to create the submodule! But can you explain "There is still the issue of data loss regarding this setting with the upgrade."?
As to me it seems you covered the problem with adding an update hook to install the submodule when pathauto is installed...
Putting this to needs review as I think this is ready. - 🇧🇪Belgium ant1
It has been a long time, but if I'm remembering it correctly: when I updated this module with this patch on a existing website, all its settings relating to Node Keep altered.
Something I don't want to happen of course.