Account created on 6 November 2018, about 6 years ago
  • Back-end developer at EcediΒ 
#

Merge Requests

More

Recent comments

πŸ‡«πŸ‡·France NicociN

For those who just need to force "table" display everywhere, here a simple patch to force "table" view mode.
It also works for CKEditor5 media library (that previous patch does not).

πŸ‡«πŸ‡·France NicociN

nicocin β†’ changed the visibility of the branch 3483196-tokens-are-html to hidden.

πŸ‡«πŸ‡·France NicociN

nicocin β†’ changed the visibility of the branch fix-3476943-theme_switcher_default to hidden.

πŸ‡«πŸ‡·France NicociN

nicocin β†’ changed the visibility of the branch 3476943-theme-switches-back to active.

πŸ‡«πŸ‡·France NicociN

nicocin β†’ changed the visibility of the branch 3476943-theme-switches-back to hidden.

πŸ‡«πŸ‡·France NicociN

What was the problem ?
For me, it seemed to be caused by mail_login ( https://www.drupal.org/project/ldap/issues/3404104 πŸ’¬ LDAP authentication is successful, but the LDAP-authenticated user cannot log in. Meanwhile, it can log in if flood attempts block the account. Closed: works as designed ), but I need to dig all possibilities.

πŸ‡«πŸ‡·France NicociN

There are cases in `ui_suite_dsfr_preprocess_pattern_footer_menu()` where `$item['url']` is an `Url`object, so we also need to check this "instanceof". I create a MR.

NB : no need to use `is_object()` as `instanceof` deals with it.

πŸ‡«πŸ‡·France NicociN

Here is the full proposed patch.

πŸ‡«πŸ‡·France NicociN

I think it'll be fixed with https://www.drupal.org/project/entity_list/issues/3446896 πŸ› Pager not rendered if multiple entity lists are declared Active .

πŸ‡«πŸ‡·France NicociN

I have to re-open the issue, because it seems that this update leads to another (new ?) issue on all our projects : the theme switch is not taken into account.

The use case : when I switch, the current page displays properly (according to selected theme), and local storage is also updated with selected theme. But on page reload (sometime we need to reload 2 or 3 times to trigger the issue), the local storage 'scheme' value is set to 'null', leading to a reset of theme (data-fr-scheme : system & data-fr-theme : [your-system-theme]).

Solution : if I comment the added JS (localStorage.setItem("scheme", null); in `ui_suite_dsfr/js/theme_switcher.js`) everything works as expected.

drupal/ui_suite_dsfr : 1.0.x-dev@dev
Browser : FF / Chrome

πŸ‡«πŸ‡·France NicociN

Can you give some more information, like what is your context (which social network, API keys set or not, ...), some more information on the issue your facing, the steps to reproduce the issue, and any other useful information.
Thanx.

πŸ‡«πŸ‡·France NicociN

A commit & a merge would be very appreciated ;)

πŸ‡«πŸ‡·France NicociN

Also working for me (v3.0.2), thanks.

πŸ‡«πŸ‡·France NicociN

It seems that the patch #46 does not writes to the proper place. This one should work well.

πŸ‡«πŸ‡·France NicociN

I tried on a fresh install, with an entity ref to node bundles, and didn't spot any problem.
Is your referenced entity viewmode-able ?

Can you write down the precise procedure to reproduce the issue ?

πŸ‡«πŸ‡·France NicociN

Hello, a little busy, will have a look probably next week.

πŸ‡«πŸ‡·France NicociN

Merged, thanks for your contribution guys !

πŸ‡«πŸ‡·France NicociN

Thanks for your review. This is merged :)

πŸ‡«πŸ‡·France NicociN

NicociN β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024