Account created on 8 March 2022, over 2 years ago
#

Merge Requests

Recent comments

coffeemakr changed the visibility of the branch 1.1.x to hidden.

coffeemakr changed the visibility of the branch 3452186-wrong-twig to active.

coffeemakr changed the visibility of the branch 3452186-wrong-twig to hidden.

coffeemakr changed the visibility of the branch 3452186-wrong-twig to hidden.

The forms listed in the honeypot module can not be extended by this module. Instead you should open a issue at the honeypot module to add simplenews integration.

Code in question:
https://git.drupalcode.org/project/honeypot/-/blob/2.1.x/src/Form/Honeyp...

From what I see here: https://vitejs.dev/guide/backend-integration the CSS and the assets are never chunks itself, only imports should be resolved as junks?

Thank you for the patch, it fixes the problem for me.

Similar implementation is done in https://www.drupal.org/project/svg_image/issues/3257729 📌 Formatters shouldn't repeat core code Needs review

@joelpittet: Of course thats correct. Here's a fixed version.

I think it would be good to extract the common functionality into a service and re-use it.

I have noticed that finalizeCart is only called in the event commerce_order.place.pre_transition (and therefore the order->cart is set to false). So the cart flag is true until the end of the checkout process.

With the current patch, functions that depend on the flag being set at the end break. For example the commerce_cart_expiration. Uncompleted order will therefore never expire.

Instead of altering the session and the order manually, the CartProvider::finalizeCart can be used.

I think this would make it more future proof and simplify the code.

I have used an alternative approach to use the default image formatter and modify the result for svg images. This ensures that modifications in the default image formatter don't have to be re-implemented in this module.

Production build 0.71.5 2024