I think the response should be cachable, at least on the client. I propose to use CacheableJsonResponse for the response.
If the caching should be configurable from the alter hooks, we could use CacheableMetadata::createFromRenderArray and a '#cache' entry in the data.
I think the field_ui module should be added to the module dependencies.
Patch works for me.
Fixed the same exception in the form-edit view when drag- and dropping.
I have applied the patch and I have encountered an error when switching the attachment strategy in the form.
The AJAX call fails with the following stacktrace:
Auf der Website ist ein unerwarteter Fehler aufgetreten. Versuchen Sie es später noch einmal.
Error: Typed property Drupal\tone\Plugin\ToneAttachmentStrategy\CssPublicFiles::$loadAsync must not be accessed before initialization in Drupal\tone\Plugin\ToneAttachmentStrategy\CssPublicFiles->buildConfigurationForm() (line 183 of modules/contrib/tone/src/Plugin/ToneAttachmentStrategy/CssPublicFiles.php).
Drupal\tone\Form\ToneTypeForm->form() (Line: 107)
Drupal\Core\Entity\EntityForm->buildForm()
call_user_func_array() (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm() (Line: 375)
Drupal\Core\Form\FormBuilder->rebuildForm() (Line: 633)
Drupal\Core\Form\FormBuilder->processForm() (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult() (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 54)
...
I have changed the declaration of $loadAync to protected bool $loadAsync = FALSE;, and it seems to fix the issue.
coffeemakr → created an issue.
coffeemakr → created an issue.
coffeemakr → changed the visibility of the branch 1.1.x to hidden.
coffeemakr → changed the visibility of the branch 3452186-wrong-twig to active.
coffeemakr → changed the visibility of the branch 3452186-wrong-twig to hidden.
coffeemakr → changed the visibility of the branch 3452186-wrong-twig to hidden.
The forms listed in the honeypot module can not be extended by this module. Instead you should open a issue at the honeypot module to add simplenews integration.
Code in question:
https://git.drupalcode.org/project/honeypot/-/blob/2.1.x/src/Form/Honeyp...
coffeemakr → created an issue.
coffeemakr → created an issue.
From what I see here: https://vitejs.dev/guide/backend-integration the CSS and the assets are never chunks itself, only imports should be resolved as junks?
Thank you for the patch, it fixes the problem for me.
Thank you for the explanation, my bad!
Similar implementation is done in https://www.drupal.org/project/svg_image/issues/3257729 📌 Formatters shouldn't repeat core code Needs review
coffeemakr → created an issue.
coffeemakr → created an issue.
@joelpittet: Of course thats correct. Here's a fixed version.
I think it would be good to extract the common functionality into a service and re-use it.
Here is a minimal patch.
coffeemakr → created an issue.
I have noticed that finalizeCart is only called in the event commerce_order.place.pre_transition (and therefore the order->cart is set to false). So the cart flag is true until the end of the checkout process.
With the current patch, functions that depend on the flag being set at the end break. For example the commerce_cart_expiration. Uncompleted order will therefore never expire.
Instead of altering the session and the order manually, the CartProvider::finalizeCart can be used.
I think this would make it more future proof and simplify the code.
coffeemakr → created an issue.
coffeemakr → created an issue.
I have used an alternative approach to use the default image formatter and modify the result for svg images. This ensures that modifications in the default image formatter don't have to be re-implemented in this module.
coffeemakr → created an issue.