Correct and simplify access checks

Hi coffeemakr,

Nice catch ; I made the changes you suggested but I am struggling on the tests changes.
I'll commit this as soon as tests will be fixed

Since we can't mock static calls with Prophecy we have to

1. Create a canAnonymousAccessNode() method

   /**
    * Tells if an anonymous user can access the node.
    *
    * @return bool
    *  TRUE if the anonymous user can access the node, else FALSE.
    */
   protected function canAnonymousAccessNode() {
     $anonymous_user = User::getAnonymousUser();
     return $node->access('view', $anonymous_user);
   }
   

2. Rewrite the whole Unit test class without Prophecy

macsim → closed merge request !23

Rewrote the tests to match what I said in #4 and merged it on 3.1.x
It would need a backport on other branches though