- 🇺🇸United States caspervoogt
I tested this and it worked for me. It solved the issue, and I saw no regressions.
- last update
about 1 year ago 32 pass - 🇫🇮Finland mmyllynen
Patch from #2 has been working nicely but looks like it needed re-rolling so here goes.
- Status changed to Closed: won't fix
about 1 year ago 11:35am 3 November 2023 - 🇩🇪Germany gbyte Berlin
Or you could just leave the '/' in custom links right as it is defined by default. The node path will then be automatically excluded as duplicate (also the default setting).
Thanks for the patch! I feel however like this is too much of a change (in terms of compatibility with extending modules) for a niche use case that will not happen with default settings, hence marking as "won't fix".
- 🇧🇪Belgium tim-diels Belgium 🇧🇪
@gbyte Just installed a clean Drupal 10 site and configured the defaults but got both the root as / and the node with its alias /homepage.
So I'm not really following why this is closed as more ppl have reported this.Is there a test that we can run to make sure this won't happen?
- First commit to issue fork.
- 🇺🇸United States caspervoogt
This is still an issue, for me at least, on at least four sites I manage. I attached a screenshot of the issue. That shows how the front page is the first link in the XML sitemap, and uses a correct link, but the sitemap also includes a node/[nid] link to the home page, and it shouldn't.
d.stoyanov → changed the visibility of the branch 3264573-update-v4.2.1 to hidden.
- Assigned to gbyte
- Status changed to Active
5 months ago 11:31am 5 September 2024 - 🇩🇪Germany gbyte Berlin
Core issue 🐛 url() should return / when asked for the URL of the frontpage Needs work which should fix this problem has not been fixed yet - I hear you guys, I'll take another look at working around this in this module soon.
- 🇧🇪Belgium f0ns
Patch in #22 was working perfect with 4.2.1 but it doesn't apply anymore on 4.2.2 and the initial problem is introduced again.
- 🇧🇪Belgium f0ns
Just checked if it was possible to alter the patch for it to work again.
Looks like it's more work than I anticipated due to https://www.drupal.org/project/simple_sitemap/issues/3484114 📌 Clean up UrlGenerator classes Active
- 🇧🇪Belgium f0ns
Just tested the new patch on 4.2.2, it works great.
Thanks a lot!