Contrib.social

Appending/removing a field item to a field item list doesn't notify the parent of the change

Open on Drupal.org →
Created on 25 July 2018, about 7 years ago
Updated 16 February 2023, over 2 years ago

Problem/Motivation

If a non-empty item is appended or removed on a field item list, the parent will not be notified about the change. If you have some listener logic in ContentEntityBase::onChange(), which is expecting to be called for the field on which an item is appended/removed, then this logic will not be triggered at all.

Proposed resolution

Notify the parent when appending/removing a non-empty item.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

10.1 ✨

Component
Entity  →

Last updated 2 days ago

Created by

🇩🇪Germany hchonov 🇪🇺🇩🇪🇧🇬

Live updates comments and jobs are added and updated live.
  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

  • Needs framework manager review

    It is used to alert the framework manager core committer(s) that an issue significantly impacts (or has the potential to impact) multiple subsystems or represents a significant change or addition in architecture or public APIs, and their signoff is needed (see the governance policy draft for more information). If an issue significantly impacts only one subsystem, use Needs subsystem maintainer review instead, and make sure the issue component is set to the correct subsystem.

  • Needs release manager review

    It is used to alert the release manager core committer(s) that an issue significantly affects the overall technical debt or release timeline of Drupal, and their signoff is needed. See the governance policy draft for more information.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 2 years ago →
    🇺🇸United States smustgrave

    This came up during the #bugsmash biweekly group triage.

    Regarding #22 personally I think it would be easier to break them up. Not sure if this warrants it's own Meta. But smaller pieces are easier to review and request changes for.

    Now this was tagged for review from almost all levels so maybe they should be the deciders of that. I will post in #needs-review-queue-initative to see if anyone can take a look.

    Am moving to NW though for D10 the new functions, parameters should be typehinted for php8.1

    New interface would require a change record as well.

    Thanks!

  • Comment 16 days ago →
    🇪🇸Spain jesus_md

    Hi, I found a bug using this patch and geofield at the same time. This patch add (['value'] = '') to the variable $gefield_item to improve the performance. However, this value cause that it doesn't enter in this if condition: URL

    It can be solved with a small path, adding also $geofield_item['value'] == '' to the if condition, so is not a big deal but I thought it could be consider in the future for new updates to this issue.

    Apart from that, the patch works well. Thanks for providing this awesome optimization.

  • Comment 14 days ago →
    🇪🇸Spain jesus_md
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024