- πΊπΈUnited States joshuasosa
FYI patch #14 doesn't seem to apply anymore on 8.x-1.0-rc1.
- Status changed to Needs work
over 1 year ago 2:46am 16 March 2023 - πΊπΈUnited States mihaic
Hi here is an updated version of the patch to works with the latest version of the module 1.0.0-rc1
- Status changed to Needs review
over 1 year ago 9:00pm 29 March 2023 - Status changed to Needs work
over 1 year ago 9:11pm 29 March 2023 - πΊπΈUnited States dww
+++ b/src/Plugin/views/argument_validator/TermNameAsId.php @@ -1,4 +1,4 @@ -<?php +x`x<?php
Whoops. Need to revert this hunk.
- Status changed to Needs review
over 1 year ago 9:13pm 29 March 2023 - Status changed to Needs work
over 1 year ago 9:33pm 29 March 2023 - πΊπΈUnited States dww
So I think we're just down to this un-addressed feedback of mine from #10:
I'm not totally thrilled about changing the view to always test with transform enabled. I wonder about only toggling that setting once we start testing that functionality. Or perhaps doing all the tests twice, with and without transform enabled?
- πΊπΈUnited States mihaic
Hi in Drupal 10 access checking must be explicitly specified on content entity queries as per https://www.drupal.org/node/3201242 β .
Here is a small update on the latest patch to add access checking and make this code Drupal 10 compatible.
+ $terms_ids = $query->accessCheck(FALSE)->execute();
Thanks