- ๐ฎ๐ณIndia kasli_harshit
Tried to apply the patch 2904468-13.patch , getting this error :
Checking patch src/MetatagManager.php...
Hunk #2 succeeded at 495 (offset 2 lines).
Checking patch tests/src/Functional/MetatagHelperTrait.php...
error: while searching for:use Drupal\Component\Render\FormattableMarkup;
use Drupal\Component\Utility\Html;
use Drupal\taxonomy\Entity\Term;
use Drupal\taxonomy\Entity\Vocabulary;
use Drupal\user\Entity\User;error: patch failed: tests/src/Functional/MetatagHelperTrait.php:4
error: tests/src/Functional/MetatagHelperTrait.php: patch does not apply - ๐บ๐ธUnited States daniel_j
Re-rolled the patch in #14 to apply cleanly to 1.x-dev
- Status changed to Needs review
about 1 year ago 5:43pm 21 September 2023 - last update
about 1 year ago 372 pass - ๐ฎ๐ณIndia kasli_harshit
Applied the Patch (#18) metatag-2904468-load_default_404_tags-18.patch , working as expected now the metatag values are rendering from backend 404/403 metatag settings , rather than node which is specified in 404 and 403 page settings.
Adding the screenshot for the same. We can move this to RTBC+1. - Status changed to RTBC
about 1 year ago 3:13pm 27 September 2023 - Status changed to Needs work
about 1 year ago 9:15pm 13 December 2023 - ๐จ๐ฆCanada dalin Guelph, ๐จ๐ฆ, ๐
Setting to "Needs Work" because
* the latest patch seems to have lost the tests from #7
* the latest patch doesn't apply on the 1.x branch, but should probably just go on the 2.x branch anyway.Upping to "normal" because the module is not doing what it says that it's going to do.
- Status changed to Needs review
12 months ago 6:45pm 19 December 2023 - last update
12 months ago run-tests.sh fatal error - ๐บ๐ธUnited States cbfannin
Rerolled for v2 and includes original tests.
- last update
12 months ago run-tests.sh fatal error - ๐บ๐ธUnited States cbfannin
My apologies. I was misusing phpcs locally and didn't catch those coding standard errors. Take 2!
- ๐ฎ๐ณIndia prashant.c Dharamshala
Prashant.c โ made their first commit to this issueโs fork.
- last update
12 months ago run-tests.sh fatal error - ๐ฎ๐ณIndia prashant.c Dharamshala
Utilized the patch supplied in #24 ๐ Load default 403/404 meta tags when node is used for those pages Needs work , generated an MR containing phpcs corrections, and performed a minor code refactor.
Thanks!
- ๐ฉ๐ชGermany Anybody Porta Westfalica
@ckng MR needs to target 2.1.x - can you change that? I don't have permission.