Account created on 12 March 2013, about 12 years ago
#

Merge Requests

Recent comments

🇺🇸United States cbfannin

Reroll as the schema information has been committed here: https://git.drupalcode.org/project/viewsreference/-/commit/ea1ea74c47c58...

So this patch now only has the sort plugin.

🇺🇸United States cbfannin

cbfannin created an issue.

🇺🇸United States cbfannin

cbfannin created an issue.

🇺🇸United States cbfannin

I did a clean install on simplytest.me with 8.x-2.10 and not seeing this issue.

My test steps were:
- Installed 8.x-2.10 (unpatched).
- Created a new Entity Browser adding the upload widget.
- Added an entity reference field to the page node type.
- Set the entity reference field's form display to Entity Browser.
- Created a new node.
- Selected an image with the new field.
- Saved the node.
- Edited the node.
- Clicked the "Removed" button.
Result: The image was removed with no reported errors.

Again this was a clean install with no patches.
If anyone wants to provide their test steps, I am more than happy to test again.

🇺🇸United States cbfannin

I did a clean install on simplytest.me with 8.x-2.9 and no longer seeing this issue.

My test steps were:
- Installed 8.x-2.9 (unpatched)
- Created a new Entity Browser adding the upload widget.
- Added an entity reference field to the page node type.
- Set the entity reference field's form display to Entity Browser.
- Created a new node.
- Selected an image with the new field.
- Saved the node.
- Edited the node.
- Clicked the "Removed" button.
Result: The image was removed with no reported errors.

Again this was a clean install with no patches.
If anyone wants to provide their test steps, I am more than happy to test again.

🇺🇸United States cbfannin

I did a clean install on simplytest.me with 8.x-2.6 and not seeing this issue.

My test steps were:
- Installed 8.x-2.6 (unpatched)
- Created a new Entity Browser adding the upload widget.
- Added an entity reference field to the page node type.
- Set the entity reference field's form display to Entity Browser.
- Created a new node.
- Selected an image with the new field.
- Saved the node.
- Edited the node.
- Clicked the "Removed" button.
Result: The image was removed with no reported errors.

Again this was a clean install with no patches.
If anyone wants to provide their test steps, I am more than happy to test again.

🇺🇸United States cbfannin

I did a clean install on simplytest.me with 8.x-2.x-dev and not seeing this issue.

My test steps were:
- Installed 8.x-2.x-dev (unpatched)
- Created a new Entity Browser adding the upload widget.
- Added an entity reference field to the page node type.
- Set the entity reference field's form display to Entity Browser.
- Created a new node.
- Selected an image with the new field.
- Saved the node.
- Edited the node.
- Clicked the "Removed" button.
Result: The image was removed with no reported errors.

Again this was a clean install with no patches.
If anyone wants to provide their test steps, I am more than happy to test again.

🇺🇸United States cbfannin

Patched Drupal 10.2.6 on PHP8.3 with MR8 and phpstan stopped reporting on this issue.

🇺🇸United States cbfannin

Removed the unnecessary return statement phpcs complained about. This is now passing.

🇺🇸United States cbfannin

Ran phpcbf and committed changes. phpcs is passing now.

🇺🇸United States cbfannin

I thought adding league/flysystem or drupal/flysystem would fix the unknown interface and unknown class errors. I was successful at adding league/flysystem but still seeing the errors locally. Requiring drupal/flysystem I would get minimum stability issues even if I set minimum stability to alpha.

It's quite possible I just have no clue what I am doing here so if you sort this out, please explain. Thanks!

🇺🇸United States cbfannin

My apologies. I was misusing phpcs locally and didn't catch those coding standard errors. Take 2!

🇺🇸United States cbfannin

Rerolled for v2 and includes original tests.

🇺🇸United States cbfannin

New patch that combines patch 5 and 9 and adds small fix for D10.

🇺🇸United States cbfannin

This doesn't appear to be an issue anymore. I did not receive the error during composer install and do not see where file_browser is being installed.

🇺🇸United States cbfannin

In following up with the environments that the remove functionality works on vs those it does not work on, I realized it works when Devel is disabled on Test and Live environments on Pantheon. The remove functionality does not work when Devel is enabled on Dev and Local. As soon as I disabled Devel on my local and tried to remove the file from the field, the remove functionality worked.

Production build 0.71.5 2024