Fix issues reported by phpcs

Ran phpcbf and committed changes. phpcs is passing now.

Hi

I applied the MR !5 and I confirmed that most of the PHPCS issues were fixed. However, there is 1 phpcs issue that remains in the module

➜  flysystem_sftp git:(8.x-1.x) curl https://git.drupalcode.org/project/flysystem_sftp/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1832    0  1832    0     0   3670      0 --:--:-- --:--:-- --:--:--  3716
patching file 'src/Flysystem/Sftp.php'
patching file 'src/Tests/ModuleInstallUninstallWebTest.php'
➜  flysystem_sftp git:(8.x-1.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml flysystem_sftp

FILE: ...-subing/Projects/d9/d9-local/web/modules/contrib/flysystem_sftp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 16 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------------

Time: 247ms; Memory: 10MB

➜  contrib git:(master) ✗ 

Retaining the status to needs review for other to replicate the same PHPCS issue I reported.

@clarkssquared,

So, as a heads up, This module is using the default Gitlab CI for Drupal template. You can see it's installation as part of the repository, and the instructions used to install it can be found here: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → .

That said, the phpcs.xml.dist used by the default CI is located here: https://git.drupalcode.org/project/gitlab_templates/-/blob/main/assets/p...

The command you used to check coding standards would not be equivalent to what was checked by CI, but goes above and beyond adding the DrupalPractice standards and additional file types.

While I appreciate any contributions that correct coding standards, Charles has satisfied my criteria for marking this task as complete. I'll leave the issue open for a few more days, as if you wish to receive credit for this issue, you will make the code changes you suggest need to be made as a Merge Request. If you wish, you may even add a custom phpcs.xml.dist that holds this module to the higher standards as a value add and ensure that Gitlab CI passes.

Thanks

clarkssquared,
I'm going to go ahead an merge the changes from cbfannin. If you by any chance wish to contribute fixes in the future for coding standards, feel free to open a new issue

Automatically closed - issue fixed for 2 weeks with no activity.