Module doesn't tolerate anything between opening and closing tags

It looks like the regular expresion https://git.drupalcode.org/project/convert_entity_media_embed/-/blob/1.0... won't match your tags because there is an   between the opening and closing tag. Obviously we can't "just" add it, because that would break it for other users. You could consider making the change yourself. That would look something like this:

          $value['value'] = preg_replace_callback(
            '/<drupal-entity(.*)data-entity-type="media"(.*)>&nbsp;<\/drupal-entity>/',
            [static::class, 'getDrupalMediaTag'],
            $originalValue
          );

I am open to suggestions to make the code more flexible in what it will accept. I am a little worried .* between the tags would inadvertently match too much.

Adjusted the issue title.

Thank you for the response and info. Thing is, the nbsp; isnt something I have put in there, it is just the default of all of my source code on multiple different sites too.

Is it possible to match the nbsp; OR nothing between the tags?

chatGPT confirmed with me this should work

$value['value'] = preg_replace_callback(
'/(?: |)<\/drupal-entity>/',
[static::class, 'getDrupalMediaTag'],
$originalValue
);

source
https://chat.openai.com/share/123fc68b-702b-49ac-86dc-4b1b3769d3ea

Sorry, Im not up to speed on submitting patches. Appreciate any help.

That’s certainly possible. I am curious what the source of that nbsp is, considering that no one has encountered it before. If we understand that, we can better assess whether we can expect other “content“ between the tags.

A very "90% easy, the rest possible" approach might also be to make the entire regex configurable... Maybe with an accompanying, mandatory, "Trust me, I know what I'm doing" checkbox...

Personally, I ended up having a different workaround for this and no longer needed to run the replace, but a configurable regex sounds like a good idea to allow broader control.

For my case, Im honestly not sure where the nbsp; came from, it was just using a normal entity embed setup to embed old D8 file entities using an Embed Button.

I like this solution, because it only accepts nothing or a single nbsp. That should not pose any risks.

Automatically closed - issue fixed for 2 weeks with no activity.