πŸ‡©πŸ‡ͺGermany @SerkanB

Account created on 18 October 2012, about 12 years ago
#

Recent comments

πŸ‡©πŸ‡ͺGermany SerkanB

I updated the info.yml, D10 is now in there.

πŸ‡©πŸ‡ͺGermany SerkanB

Nice, thanks for that :D

Lets see if I get the whole "givin credits" thing right...

πŸ‡©πŸ‡ͺGermany SerkanB

hmmm nope, not that I know of. I just didn't test it yet with a clean D10 install, as I was working on D9.

Hadn't have time to finalize it even for D9. I'll try to test it on D10, and if it works there as well, I surely can add a D10 release/add d10 as compatible.

πŸ‡©πŸ‡ͺGermany SerkanB

So anyone who is looking for this, I've turned my first working state into a module : https://www.drupal.org/project/lpb/ β†’

It's still not 100% ready, hence the dev-release, but it works... basically.

Right now it's overriding the route to use a new Controller... but I would like to implement the whole thing as a seperate Widget for the layout_paragraphs-field, that somehow keeps the layout-functionality intact.

Issues and Patches are of course welcome :D And once we have the browser running, maybe we can integrate the browser_previewer in that module... maybe.

πŸ‡©πŸ‡ͺGermany SerkanB

Sounds a lot like this issue here just with fields instead of permissions:
https://www.drupal.org/project/config_split/issues/3310931 πŸ› Role/Permission are added to multiple splits Fixed

And there are probably other configurations where this happens. Anything that's shared between different entities/stuffβ„’. It seems to be a difficult problem to solve.

πŸ‡©πŸ‡ͺGermany SerkanB

Changing status to active, as my go on a fix didn't change anything :(

πŸ‡©πŸ‡ͺGermany SerkanB

The easiest fix would be to implement the form_alter with the new ID and call the old form_alter...

function focal_point_form_media_library_add_form_dropzonejs_alter(array &$form, FormStateInterface $form_state) {
  focal_point_form_media_library_add_form_upload_alter($form, $form_state);
}

But this feels wrong, having some hook of a random contrib module. Is this the way to go?

πŸ‡©πŸ‡ͺGermany SerkanB

Looks like this is caused by a recent change on the dropzonejs side.
There is already an issue ( https://www.drupal.org/project/focal_point/issues/3344369 πŸ› Compatibility with DropzoneJS Active ) linking to the issue that caused the change ( https://www.drupal.org/project/dropzonejs/issues/3341846 πŸ› Set custom form id for media library form Fixed )

So I would close this as duplicate.

πŸ‡©πŸ‡ͺGermany SerkanB

@jonathan1055 you sir are correct!

Removing the patch and adding those {} works just fine.

Well then, forget what I said. Reading the docs properly would've saved me from all this.

πŸ‡©πŸ‡ͺGermany SerkanB

If I remember correctly, the issue just was: if I add "@inheritdoc", I do that because there is already a doc-comment somewhere, I don't want to replicate that.

Without the return there, it did his job and told you "please write a comment!", which isn't the point of "@inheritdoc" :D (maybe even @inheritDoc ... should've added that in there as well.)

πŸ‡©πŸ‡ͺGermany SerkanB

Fix for #1 works fine.

#2 I wasn't that easy, simply doing it as I described skips all the assets. That's because in the copyPath()-method the path is being altered before file_exists() is called. I left it as is (for now)

Production build 0.71.5 2024