Contrib.social

Remove default colon behind inline labels

Open on Drupal.org →
Created on 22 December 2016, almost 8 years ago
Updated 19 May 2023, over 1 year ago

Problem/Motivation

The formatter adds a default colon behind the inline label, as example in in date fields.
This is bad practice. In some languages, like Greek, colon is not even used.
If people want colon on their labels, they can easily add it themselves.

Check this comment;
#67211-41: Show colon after form title only when there is no other punctuation →

And what happens when you have a label with other punctuations, like questions marks?
#67211: Show colon after form title only when there is no other punctuation →

Steps to reproduce

Proposed resolution

Do something like add it in PHP/twig as a translatable string + context then let people translate it to empty string. See #22.

Remaining tasks

Create a follow up, see #22.
Patch
Test
Review

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs work

Version

9.5

Component
CSS  →

Last updated 1 day ago

Created by

🇳🇴Norway matsbla

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    29,388 pass
  • Comment over 1 year ago →
    🇮🇳India gauravvvv Delhi, India

    I have updated it for all the themes expect starterkit theme. I have attached a patch for same. please review

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    Saw the removal which addressed the first part but didn't see "As for a solution the agreement was to do something like add it in PHP/twig as a translatable string + context then let people translate it to empty string"

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024