View without empty handling could break caching

Hello,

The current patch causes the title to be displayed even though the view has no results.

Wouldn't it be enough to return the cache tags when the view has no results instead of rendering it anyway?

I upload a new patch doing it this way.

Thanks!

The following patches all conflict and work on the same issue and piece of code:
🐛 ViewsReferenceFieldFormatter does not check for headers set to show on empty. Fixed
🐛 ViewsReferenceFieldFormatter does not render view if it has no results Fixed
🐛 View without empty handling could break caching Needs review

A fix for this has been added in 🐛 Viewsreference embeds Views without cache, breaking Dynamic page cache Fixed . Could you please check the latest dev version and let me know if this issue has been resolved?

It works. Thanks @seanB

so should this be closed as a dupe of 🐛 Viewsreference embeds Views without cache, breaking Dynamic page cache Fixed ?

Since the existing of the 2 formatters now (ViewsReferenceLazyFieldFormatter and ViewsReferenceFieldFormatter) this is still an issue for the latter. I have created a Merge Request and hidden the patches. The original patch only handles cache tags, but actually the full cache settings of the View should be respected. For example, when using a Search API SOLR View, if there is an exception thrown, max-age is set to 0 so next load attempts again to contact SOLR - the formatter should respect that.

So I was able to reproduce this by

1. Creating a View that uses Search API / Search API SOLR
2. Causing an issue with SOLR so an exception is thrown at here
3. Load the node with the Views Reference field - no results as expected
4. Fix SOLR issue
5. Load the node with the Views Reference field - no results still, since the earlier load has cached this

Applying the diff from @scott_euser's MR as a composer patch fixes this issue in my testing.

I'm attaching a static copy here so we can use this on our sites.

Hiding the patch to avoid confusion with merge request (side note: you can download the patch to apply locally as per recommended instructions → )

Tested MR, it works like a charm. +1 for RTBC

The patch here fixes the issue for me where when accessing the page with a bad / wrong query parameter for the contextual filter with cold caches the page gets cached without the view and then accessing the page again without any query parameter returns again the page without the view instead of showing the view with all available filters.

Fixed, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.