Test group implementation

Eric, can you test again? I pushed new permissions, so that group admins no longer can delete their own group (but global admins will be able to delete groups even when they are not members).

I'll test it asap

New round of tests during Perpignan Barcamp :

Outsider

see Test permissions group i’m not member tests of each role

Member

Note : The user is automatically accepted in group hence he can create group stories right after join), i think stories creation might be limited either by an higher group role or by a people role eg. confirmed (i guess we could eventually rely on community validation as it’s used on drupal.org to confirm. people are not spammers).

Test permissions in my group:
add story > yes OK

Can create stories in his groups but cannot edit or delete those is it normal ?

make suggestions > yes Ok
moderate suggestion > no OK
self moderate > no OK

Test permissions group i’m not member:
add story > no OK
make suggestions > no OK

moderate suggestion > no OK

self moderate > no OK

Translation self-moderator

Test permissions in my group:
add story > yes OK

make suggestions > yes OK

moderate suggestion > yes OK

self moderate > yes OK

Can create stories in his groups but cannot edit or delete those is it normal ?

Test permissions group i’m not member:
add story > no OK

make suggestions > no OK

moderate suggestion > no OK

self moderate > no OK

Translation community moderator

Test permissions in my group:
add story > yes OK

make suggestions > yes
 OK
moderate suggestion > yes OK

self moderate > no OK ?

Can create stories in his groups but cannot edit or delete those is it normal ?

Test permissions group i’m not member:
add story > no OK

make suggestions > no OK

moderate suggestion > no OK

self moderate > no OK

Translation community manager

Test permissions in my group:
add story > yes OK

make suggestions > yes OK

moderate suggestion > no KO

self moderate > no KO


Maybe it's ok not to allow moderation and is intended to be used alonside with Translation community moderator when needed (which would make sense imho), can you confirm ?

Can create stories in his groups and edit or delete any stories in his groups OK

Test permissions group i’m not member:
add story > no OK
make suggestions > yes OK

moderate suggestion > no OK

self moderate > no OK

Admin

Test permissions in my group:
add story > yes OK

make suggestions > yes OK

moderate suggestion > no KO ?

self moderate > no KO ?

Test permissions group i’m not member:
add story > no OK

make suggestions > no OK

moderate suggestion > no OK

self moderate > no OK
Can edit his groups > OK
Can manage groups members OK

Can create stories in his groups and edit or delete any stories in his groups OK

Questions :
NOTE: a group member doesn't have a link to leave a group is it normal ?

Any authentificated user has import tab avalilable on all groups (even when not in this group) bu the import trigger the following error
The website encountered an unexpected error. Try again later.

TypeError: Drupal\file\Upload\FileUploadHandler::handleExtensionValidation(): Return value must be of type string, null returned in Drupal\file\Upload\FileUploadHandler->handleExtensionValidation() (line 431 of core/modules/file/src/Upload/FileUploadHandler.php).
Drupal\file\Upload\FileUploadHandler->handleFileUpload(Object, Array, 'temporary://', Object, ) (Line: 660)
file_save_upload('file', Array, 'temporary://', 0) (Line: 143)
Drupal\l10n_community\Form\ImportForm->submitForm(Array, Object)

@ericdsd thanks! Could you please review 🐛 Translation suggestion creation and moderation don't provide group permission Active first, and perhaps amend your report, as I fear there might be interferences between both issues?

For the record, you will need to configure group permissions at /admin/group/types/manage/translation/permissions#module-l10n_groups (since the MR is not merged yet, I cannot provide the corresponding configuration, which is stored in another repo).