Fix Circular Reference by Removing Autowire and Minimizing Dependencies in modeler_api.service

Thank you @rajab natshah for reporting this and proposing a solution. I'm surprised this is happening in your installation, since I'm using Drupal 11.2 and ECA 3 on many sites, including the development environment. And I haven't seen that issue before. Before we give in on this one, can we somehow find out why this is happening?

I have a big stack of modules and CIs.
+ multiple languages
For exmaple scheduler, paragraphs, consumer.

Fined out

In Container.php line 147:
                                                                                                                                                                                 
  Circular reference detected for service "Drupal\Core\Logger\LoggerChannelFactoryInterface", path: "scheduler.manager -> logger.channel.scheduler -> Drupal\Core\Logger\Logger  
  ChannelFactoryInterface -> logger.syslog -> Drupal\modeler_api\Hook\EntityHooks -> modeler_api.service -> router.route_provider -> cache_tags.invalidator -> plugin.manager.b  
  lock -> logger.channel.default".                                                                                                                                               
                                   

In DefinitionErrorExceptionPass.php line 48:
                                                                                                                                                                                 
  [Symfony\Component\DependencyInjection\Exception\RuntimeException]                                                                                                             
  Cannot autowire service "Drupal\modeler_api\Hook\EntityHooks": argument "$modelerApiService" of method "__construct()" references class "Drupal\modeler_api\Api" but no such   
  service exists. You should maybe alias this class to the existing "modeler_api.service" service. 

In DefinitionErrorExceptionPass.php line 48:
                                                                                                                                                                                 
  [Symfony\Component\DependencyInjection\Exception\RuntimeException]                                                                                                             
  Cannot autowire service "Drupal\modeler_api\Hook\EntityHooks": argument "$modelerApiService" of method "__construct()" references class "Drupal\modeler_api\Api" but no such   
  service exists. You should maybe alias this class to the existing "modeler_api.service" service.  

Still testing the first draft fix with AI

Impressive module, by the way (thanks for working on it).
Could a new 2.0.x branch help?
So we don't manage old and new ways within the same codebase.

Drupal ~11.2.0 is doing things a new way, and contrib modules haven't caught up to it yet.
Trying to find a smoother mechanism and method for the update process.

Attached a static modeler_api--2025-07-24--3537810--mr-8.patch file, for this point of MR8.
To be used with Composer Patches and Drupal ~11.2.0

Originally, this module was only meant to work for Drupal 11.2 and later. For several reasons, we opened it up to be available for Drupal 10.4 as well, something I wasn't keen to do, but that's what it is now. Therefore, just now already opening another branch is not a priority. Let's avoid that if not absolutely necessary.

Still, I can't reproduce the issue, neither on 11.2 nor on earlier versions. So, I don't know exactly what we should be doing as it doesn't seem to be a general issue. I think before we can make further decisions, we need some reproducible instructions.

And BTW, uploading patches for composer is really bad practice. The DA makes it clear wherever they can, there is no guarantee that those files will be available. Patches have to be downloaded from the MR locally and applied from there,

Noted;
Thanks for following up on this issue. As I said, we have a big stack of modules.
I did not change the status of the issue to needs review yet, but you started reviewing. ( Thank you for being on the spot )
For sure, Next time, I will add the Steps to reproduce when filing issues. I thought that when I sat on the final fix, I would add them.

Let's rest this issue. ( We manage a local patching system in all projects, only shared to make it public for search)
We added the Modeler API module to our products. with ECA.

It is the standard for my team to Managing Only Local Patches for Projects

Varbase has the Drush Command to Clean up Any Merge Request Patches

Drupal CMS switched to use Local Patching system!! too
https://git.drupalcode.org/project/drupal_cms/-/tree/2.x/patches?ref_typ...
https://git.drupalcode.org/project/drupal_cms/-/commit/318f64b7126208d15...
https://git.drupalcode.org/project/drupal_cms/-/blob/2.x/dev.composer.js...

Jürgen, moving to follow with your tip.
To use our patching storage. not to keep uploading/attaching a copy of MRs.
Thanks, I cooked your remark overnight, and you are right on this.

Back to the issue
We are using ECA, BPMN.iO with Modeler API in both Drupal 10.5.0 for some old projects, and Drupal ~11.2.0 too

rajab natshah → changed the visibility of the branch 3537810-fix-circular-reference to hidden.

Moving to manage our local patch.
Something is wrong with the issue fork in this issue.

rajab natshah → changed the visibility of the branch 1.0.x to hidden.

rajab natshah → changed the visibility of the branch 3537810-01x00x-for-D11x02 to hidden.

rajab natshah → changed the visibility of the branch 3537810-1-0-x to hidden.

Okay, looks like it can't be solved.
So, what is the recommendation in this case?
If we look at the situation from the ECA perspective, what advice would you give?
Should we continue with ECA v.2 or revert to v2?
Because this problem started with the models_api requirement of ECA v.3.
Thanks

I wish I could reproduce this. I have Drupal 11.2 and around 100 contrib modules enabled. And this problem doesn't happen to me. So, my suspicion is that some (maybe exotic) contrib module is doing something that triggers this, and it only seems to be related to modeler API but may be caused by something else.

To further work on this, we would have to find the route cause of this. For that, you would have to start with a vanilla Drupal 11.2 installation, add Modeler API, ECA, and BPMN.io and enable them all. The problem should not be present. Then you may want to enable more of your modules one by one, and always run drush cr after enabling another new module. At some point, the circular exception may show up again. Then we would want to know which new module caused this. At that point we can try if we can reproduce this with that module.

I will follow up with this.

you may want to enable more of your modules one by one, and always run drush cr after enabling another new module. At some point, the circular exception may show up again.

Thanks, Jürgen, for the hint instruction.