- Issue created by @quietone
- Status changed to Needs review
6 months ago 8:37am 10 February 2024 - π³πΏNew Zealand quietone New Zealand
I started with 'itok' which is only used in 4 files so that seemed reasonable to remove from the dictionary. And that is true for others with a small number of file changes. But then I found that 'linkset' is in json files so we can't add a comment there to ignore it. And 'datelist' is used in a lot of twig files and we haven't yet added cspell ignore lines there.
The MR shows the changes I made to that point. But now I think it would be better to move these to drupal.txt:
- anyall
- datelist - ~23 file include many twig files
- daterange
- filemime - About 35 usages in multiple subsystems and modules.
- fulldate
- groupby - ~19 files
- groupwise
- itok - 4 files
- linkset Used in .json files
- prerender
- sitename
- subquery - ~30 files
- unpromote
- unpublish
- unsticky
and only change this one
- fieldblock - this is in only in test files in layout_builder
We could make followup to change say 'datelist' to 'date_list' or 'anyall' to 'any_all' but does that add value?
- Status changed to Needs work
6 months ago 3:05pm 12 February 2024 - πΊπΈUnited States smustgrave
If we stick to just those 2 (datelist and anyall) I think they could be handled here.
As far as the list to move to the drupal dictionary I think they all made sense, know personally some of those I've used often in conversation.
- Status changed to Needs review
6 months ago 12:41am 13 February 2024 - π³πΏNew Zealand quietone New Zealand
If we stick to just those 2 (datelist and anyall) I think they could be handled here.
Can you elaborate? There are no changes here for datelist.
- πΊπΈUnited States smustgrave
Your last comment
We could make followup to change say 'datelist' to 'date_list' or 'anyall' to 'any_all' but does that add value?
Think they can be handled here.
- π³πΏNew Zealand quietone New Zealand
But that doesn't answer the question if doing so adds value? Not to mention there will be BC to deal with.
- Status changed to RTBC
5 months ago 7:54pm 16 February 2024 - πΊπΈUnited States smustgrave
To not hold this one up opened π Determine value in update datelist and anyall Active
- Status changed to Needs work
5 months ago 4:31pm 17 February 2024 - π¬π§United Kingdom longwave UK
As stated in another one of these issues I don't think we should be adding these to config, as they are (pretty much) machine generated and don't care about retaining comments if they are recreated.
#3 makes a good point that most of these words look like they should be added to the Drupal dictionary.
I think these are all valid candidates:
- anyall (mostly because this will be hard to change)
- datelist (mostly because of the number of usages)
- daterange (this is a field type name, so a Drupalism)
- filemime (widely used)
- groupwise
- linkset (see https://www.rfc-editor.org/info/rfc9264)
- prerender
- subquery
- unpromote
- unpublish
- unsticky
Not so sure about
itok
(this is an abbreviation of "image token", but not a word) orfulldate
,groupby
orsitename
(made up compound words). - π³πΏNew Zealand quietone New Zealand
#9. I moved the drupalisms to the drupal dictionary. Still need to work on the other words.