Misspellings in schema files

Created on 10 February 2024, 6 months ago
Updated 5 March 2024, 5 months ago

Problem/Motivation

This is for for words that are used in schema files.

  1. anyall
  2. datelist - ~23 file include many twig files
  3. daterange
  4. fieldblock - this is in only in test files in layout_builder
  5. filemime - About 35 usages in multiple subsystems and modules.
  6. fulldate
  7. groupby - ~19 files
  8. groupwise
  9. itok
  10. linkset Used in .json files
  11. prerender
  12. sitename
  13. subquery - ~30 files
  14. unpromote
  15. unpublish
  16. unsticky

Steps to reproduce

Proposed resolution

Move to Drupal dict

  • daterange (this is a field type name, so a Drupalism)
  • prerender (a Drupalism)
  • unpromote (a Drupalism)
  • unpublish (a Drupalism)
  • unsticky (a Drupalism)

Merge request link

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
OtherΒ  β†’

Last updated less than a minute ago

Created by

πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @quietone
  • Merge request !6534Resolve #3420570 "Misspellings in schema" β†’ (Open) created by quietone
  • Status changed to Needs review 6 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    I started with 'itok' which is only used in 4 files so that seemed reasonable to remove from the dictionary. And that is true for others with a small number of file changes. But then I found that 'linkset' is in json files so we can't add a comment there to ignore it. And 'datelist' is used in a lot of twig files and we haven't yet added cspell ignore lines there.

    The MR shows the changes I made to that point. But now I think it would be better to move these to drupal.txt:

    1. anyall
    2. datelist - ~23 file include many twig files
    3. daterange
    4. filemime - About 35 usages in multiple subsystems and modules.
    5. fulldate
    6. groupby - ~19 files
    7. groupwise
    8. itok - 4 files
    9. linkset Used in .json files
    10. prerender
    11. sitename
    12. subquery - ~30 files
    13. unpromote
    14. unpublish
    15. unsticky

    and only change this one

    1. fieldblock - this is in only in test files in layout_builder

    We could make followup to change say 'datelist' to 'date_list' or 'anyall' to 'any_all' but does that add value?

  • Status changed to Needs work 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    If we stick to just those 2 (datelist and anyall) I think they could be handled here.

    As far as the list to move to the drupal dictionary I think they all made sense, know personally some of those I've used often in conversation.

  • Status changed to Needs review 6 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    If we stick to just those 2 (datelist and anyall) I think they could be handled here.

    Can you elaborate? There are no changes here for datelist.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Your last comment

    We could make followup to change say 'datelist' to 'date_list' or 'anyall' to 'any_all' but does that add value?

    Think they can be handled here.

  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    But that doesn't answer the question if doing so adds value? Not to mention there will be BC to deal with.

  • Status changed to RTBC 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    To not hold this one up opened πŸ“Œ Determine value in update datelist and anyall Active

  • Status changed to Needs work 5 months ago
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    As stated in another one of these issues I don't think we should be adding these to config, as they are (pretty much) machine generated and don't care about retaining comments if they are recreated.

    #3 makes a good point that most of these words look like they should be added to the Drupal dictionary.

    I think these are all valid candidates:

    • anyall (mostly because this will be hard to change)
    • datelist (mostly because of the number of usages)
    • daterange (this is a field type name, so a Drupalism)
    • filemime (widely used)
    • groupwise
    • linkset (see https://www.rfc-editor.org/info/rfc9264)
    • prerender
    • subquery
    • unpromote
    • unpublish
    • unsticky

    Not so sure about itok (this is an abbreviation of "image token", but not a word) or fulldate, groupby or sitename (made up compound words).

  • Pipeline finished with Success
    5 months ago
    Total: 556s
    #111620
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    #9. I moved the drupalisms to the drupal dictionary. Still need to work on the other words.

Production build 0.69.0 2024