- Issue created by @acbramley
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Thanks for reporting. We actually need to remove
\OpenSearch\Common\Exceptions\OpenSearchException
as it is deprecated inopensearch-project/opensearch-php
2.4.0 - π¦πΊAustralia acbramley
Yeah I thought about doing that here but wasn't entirely sure what it should be replaced with, maybe just the interface?
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
We should be able to just catch
OpenSearchExceptionInterface
as we convert any HTTP responses with status >= 400 to an instance of\OpenSearch\Exception\HttpExceptionInterface
which extends\OpenSearch\Exception\OpenSearchExceptionInterface
. - π¦πΊAustralia acbramley
That doesn't work for the original issue in the IS (it's still GuzzleHttp\Exception\ConnectException)
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Hmm. What version of
opensearch-php
are you using? - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Updated to catch both OpenSearchExceptionInterface and ClientExceptionInterface
-
kim.pepper β
committed 8cde3947 on 3.x authored by
acbramley β
Issue #3530261 by acbramley, kim.pepper: Catch ClientExceptionInterface...
-
kim.pepper β
committed 8cde3947 on 3.x authored by
acbramley β
-
kim.pepper β
committed 3ad7eb89 on 2.x
Issue #3530261 by acbramley, kim.pepper: Catch ClientExceptionInterface...
-
kim.pepper β
committed 3ad7eb89 on 2.x
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Committed to 3.x and 2.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.