- Issue created by @valegole
Is this saying that if the PHP intl extension is installed, the transliteration is correct? Or, do you mean that in any case some code must change?
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I think we need an answer to #3
- 🇳🇿New Zealand quietone
In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Also mentioned on the version → section of the list of issue fields documentation.
- 🇩🇪Germany valegole
#3 🐛 Incorrect filename transliteration on upload due to missing Unicode normalization (e.g., Mönchengladbach.png → Monchengladbach.png instead of Moenchengladbach.png, which also affects German umlauts) Active The PHP intl extension is installed, and even with that, the transliteration is still incorrect.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Thanks for the explanation and the MR. This needs a test so we can show it failing before and fixed after.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I made a naive attempt at a test. I'm not proficient any any other language besides English, so would like someone to weigh in and ensure we have the right test coverage here.
Ran the test-only pipeline to see if it fails as expected.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Test-only pipeline did not fail as expected.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I used xdebug to work through this code locally and the test skips
\Normalizer::normalize()
becauseclass_exists('Normalizer')
returns false.However, it successfully converts
ö
tooe
in\Drupal\Component\Transliteration\PhpTransliteration::replace()
and so the test passes.I can't really take this any further until we get some input from the transliteration maintainer (@amateescu). I'm changing the component to transliteration system for that.