Removed deprecated code in File module (core/module/file)

Cleanup all deprecated calls, except those in *Test.php files.

Not sure if classes related to "Tests legacy deprecated functions in file.module." should just be totally deleted or left there?

• FileSaveUploadTest.php
• FileUploadHandlerTest.php
• LegacyFileModuleTest.php
• LegacyFileThemeTest.php
• LegacyValidateTest.php
• LegacyValidatorTest.php

Merging pipeline made obvious we had to clean Test classes and even entirely delete Legacy ones, so there.

That said, there are still some unit testing errors which I can't figure out entirely.

There's still a call to a function isValid() which I removed as it was marked as deprecated.
See core/modules/file/src/Upload/FileUploadHandler.php:195

But now unit testing shows plenty of errors.
I'm stopping here for now, feel free to jump in.

Possible the deprecation was tested and those tests would need to be removed too.

But if removing this function breaks things we may need to re-look at if some replacements were missed when it was first deprecated

kim.pepper → made their first commit to this issue’s fork.

I've cleaned up some the left over deprecation code. However, I think I've hit a bug with the Validatable config job.

Unable to install modules: module 'help_topics' is obsolete.

Added fix to see if test will pass, probably it needs separate issue (follow-up) after 📌 Remove deprecated help_topics module Needs review

but still not clear why nobody reported this earlier

#9 created a separate issue 🐛 Validatable config should skip obsolete modules Needs review

Removal appears complete.

Applied the MR and searched core/module/file folder for deprecated and 11.0 and all instances have been removed.

Thanks for working on this - looking good, just a couple of missed spots.

Addressed feedback.

Coming back to this after a long while, I am wondering why we didn't deprecate hook_file_validate() at the time?

Appears feedback from @longwave has been addressed.

Created 📌 Deprecate hook_file_validate() Active

This should remove hook_file_validation from file.api.php .... it is deprecated we do

$errors = array_merge($errors, $this->moduleHandler->invokeAllDeprecated('Use file validation events instead. See https://www.drupal.org/node/3363700', 'file_validate', [$file]));

And this change is removing that line so the hook is no longer trigger so it should remove it from file.api.php.

Removed hook_file_validate() and doc references to calling file_validate()

back to RTBC

Committed 08c0efd and pushed to 11.x. Thanks!

We need to revert this as the changes made in 📌 Create an UploadedFile validator and deprecate error checking methods on UploadedFileInterface RTBC need a rework prior to 10.3.0 being released.

This is unblocked now that 🐛 \Drupal\file\Upload\FileUploadHandler::handleFileUpload() should alway check that the uploaded file is valid Fixed is in.

Cleaned up after a few merge conflicts.

Missed one, otherwise this looks good to me:

core/modules/file/src/Plugin/rest/resource/FileUploadResource.php:    @\trigger_error(__METHOD__ . ' is deprecated in drupal:10.3.0 and is removed from drupal:11.0.0. Use \Drupal\file\Upload\FileUploadLocationTrait::getUploadLocation() instead. See https://www.drupal.org/node/3406099', E_USER_DEPRECATED);

except nitpick I find it RTBC

Was about to do the same beat me to it! Tests all green and deprecation appears to be removed here.

Committed/pushed to 11.x, thanks!

MR needs to be closed.

longwave → closed merge request !7148

Automatically closed - issue fixed for 2 weeks with no activity.

We missed a few methods on \Drupal\file\Upload\InputStreamUploadedFile

Created 📌 [11.x] Remove deprecated methods in InputStreamUploadedFile Active