- Issue created by @kim.pepper
- Status changed to Closed: duplicate
8 months ago 11:22pm 1 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
We did deprecate hook_file_validate - we currently trigger it like
$errors = array_merge($errors, $this->moduleHandler->invokeAllDeprecated('Use file validation events instead. See https://www.drupal.org/node/3363700', 'file_validate', [$file]));
the issue removing the deprecated code is removing that line so it should also be responsible for removing it from file.api.php.
- π¬π§United Kingdom alexpott πͺπΊπ
See also the CR that clearly says the hook is deprecated - https://www.drupal.org/node/3363700 β - and was probably written by @kim.pepper :)
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Ah yes. But we also should have deprecated the hook in
file.api.php
docblock according to https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... β - Merge request !7277#3437514 Deprecate hook_file_validate() and doc references β (Closed) created by kim.pepper
- Status changed to Needs review
8 months ago 1:45am 2 April 2024 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Created a MR to show what I mean.
- Status changed to RTBC
8 months ago 8:12am 2 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Let's commit this to 10.3.x and 10.2.x then :)
- Status changed to Fixed
8 months ago 10:34am 2 April 2024 - π¬π§United Kingdom catch
Committed/pushed to 10.3.x and cherry-picked to 10.2.x, thanks!
-
alexpott β
committed 5f6c6ec6 on 11.x authored by
catch β
Issue #3437514 by kim.pepper, alexpott: Deprecate hook_file_validate()...
-
alexpott β
committed 5f6c6ec6 on 11.x authored by
catch β
- π¬π§United Kingdom alexpott πͺπΊπ
Cherry-picked to 11.x because π PP-1: Removed deprecated code in File module (core/module/file) Postponed got reverted for now and will need to be reworked prior to it going in again.
Automatically closed - issue fixed for 2 weeks with no activity.