Replace deprecated help_topics module with obsolete stub

After applying the MR I still see a few textual references to the help_topics module and at least two test modules with the name help_topics in them.

I guess we want to remove all of those as well?

@Spokje I see no mentions, all from git grep help_topics is related to help module

Only update hooks has 2 mentions but I see no reason to remove it

Ah, so something like hook_help_topics_info_alter is actually used by the help module?

Yes, help topics are plugins)

btw it's time to release as project https://www.drupal.org/sandbox/jhodgdon/2369943 →

All removal so easy to review. Removal didn't break anything so looks fine to me.

I don't think we can go straight to removal. The problem is that if you have a site with help_topics enabled, and update to 11.x, you'll get the missing module error message, then you can't uninstall it because it's not in the filesystem.

For previous merged modules, we've marked them obsolete, with an update to uninstall them, and a hook_requirements() to prevent them being re-installed. That guarantees the module is uninstalled everywhere, so it can then be safely removed in 12.x

All the other code can be removed though, so most of the MR is fine.

The module is uninstalled by help module's post update hook, so we can remove it safely until the hook is here

update hook is not enough as screenshot points, so I marked module obsolete

so it allows to remove the obsolete stub in 12.x

This looks good but it also needs a hook_requirements() to prevent the module being re-installed. Any existing or 9.5 obsolete module should have one as an example.

So the stub should be obsolete and hidden, and all tests pass

Hope the better title and may need CR

But there's existing CR https://www.drupal.org/node/3382015 → which can be linked here

updated IS

Still needs the hook_requirements() to prevent the module from being enabled.

obsolete/hidden state - means it can't be installed via UI and prevents drush from doing it

/var/www/html/web $ drush en help_topics

In ModuleInstaller.php line 122:
                                                                
  Unable to install modules: module 'help_topics' is obsolete.  

But the module still available to uninstall via UI!

Sorry I forgot we added this support to obsolete modules centrally instead of the hook_requirements(), in that case, it looks good to me!

Committed 31e7810 and pushed to 11.x. Thanks!

andypost → closed merge request !7162

There's follow-up for CI job 🐛 Validatable config should skip obsolete modules Needs review

Automatically closed - issue fixed for 2 weeks with no activity.