Finalize the merge of Help Topics into Help

All conversions are done so it's time for final merge or keep them separated

Amber Himes Matz → made their first commit to this issue’s fork.

Updated IS to remove mention of Stable/Classy.

I’m not sure what else needs to be done with regard to adding templates to core admin themes.

I’ve opened a MR that:

- Adds new help topic in core Help module to replace Help Topic module overview in its hook_help.
- Moves help.help_topic route case to help_help().
- Deletes help_topic.module, as all other hooks are already being moved in 📌 Merge Help Topics classes into Help with BC layer Fixed .

This is ready for review. The following items from the IS are addressed in this MR:

• Merging the hook_help() from the experimental Help Topics module into existing topics
• Making sure that no help topics mention the Help Topics module (because it will be part of the Help module instead).

I also opened 📌 Update help.help_topic_search to remove mention of Help Topics module Fixed which will need to wait until 📌 Merge Help Topics classes into Help with BC layer Fixed is committed.

All other points except for the “the standard things done in Core to finalize a module such as adding templates to core admin themes, etc” are covered in related issues.

That being said, there may be something else that @andypost thinks should go into this issue, that isn’t part of the MR in 📌 Merge Help Topics classes into Help with BC layer Fixed .

Thank you! That's exactly chicken/egg issue I stuck to figure out!

I think I need to review/check all @internal mentions in topics to be sure that all classes without BC has it

Ref https://www.drupal.org/about/core/policies/core-change-policies/bc-policy →

btw We may reconsider to open after final merge #2687107-41: Reorganize topics into sensible outline, and/or write more topics →

Only moving to NW as there appear to be failures in the MR.

Have not tested yet.

Latest push restores help_topics.module as suggested by @andypost -- it just provides a message saying that Help Topics has been moved to Help module.

I thought I had already done this, but apparently not -- I merged the output from Help Topics' module overview to Help modules. So Help module's module overview page now includes info about Help Topics.

Finally, I updated the branch target to 11.x as requested.

It looks ready so new should wait for merge of 📌 Merge Help Topics classes into Help with BC layer Fixed

Seems some failures in MR but based on #23 this is postponed

Final merge should mark help topic module obsolete https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsolete →

Squashed commits and now it's not clear if this changes from the MR could me added to 📌 Merge Help Topics classes into Help with BC layer Fixed

Here's diff (rebase MR on top of 3087499)

Yes, I think it makes sense to incorporate the changes here into #3087499 instead.

Moved to #3087499-51: Merge Help Topics classes into Help with BC layer →

Proper starts

updated IS a bit

it will need to update https://www.drupal.org/about/core/policies/core-change-policies/experime... →

Filed 📌 Update Maintainers for the Help module Fixed

After 📌 Merge Help Topics classes into Help with BC layer Fixed , all the classes under help_topics/src/ are simply wrappers for the corresponding classes in the help module.

Should we also mark those classes as deprecated? Maybe we do not have to, since they are already marked @internal. But I think this comment from https://www.drupal.org/about/core/policies/core-change-policies/bc-polic... → applies:

Even for internal APIs, core contributors should always try to follow the deprecation process first, or document in issue discussions why deprecation is not used.

The main point is not to add them is that help topics module is experimental and should not contain API

Filed patch for the last issue #3074040-15: Move testing of help topic rendering into InstallUninstallTest →

All others are RTBC)

one more commited 📌 Update help.help_topic_search to remove mention of Help Topics module Fixed

The only one is left 📌 Add help_search plugin to the base admin theme test Fixed

Amber Himes Matz → closed merge request !3934

Filed quick-fix 📌 Remove leftover mentions of help_topics namespace in help module Fixed

The quick-fix needs docs team review so can live on its own 📌 Remove leftover mentions of help_topics namespace in help module Fixed

I find this epic complete and polishing will happen as docs evolving

Automatically closed - issue fixed for 2 weeks with no activity.